8000 [FrameworkBundle] [TwigBundle] Move debug commands to debug namespace by matthieuauger · Pull Request #11627 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[FrameworkBundle] [TwigBundle] Move debug commands to debug namespace #11627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

matthieuauger
Copy link
Contributor
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
Tests pass? yes
Fixed tickets -
License MIT

Instead of having several namespaces with only one debug command (container:debug, event-dispatcher:debug), move all these debug commands to a new debug namespace.

Related to #10388 (comment)

I don't how to tag these aliases as deprecated as there are only here for backward compatibility.
The renaming should also be done in the Swiftmailer Bundle.

@stof
Copy link
Member
stof commented Aug 12, 2014

👍

Can you also send a PR on SwiftmailerBundle ?

@romainneutron
Copy link
Contributor

👍

@matthieuauger
Copy link
Contributor Author

Here it is : #11627

Your votes/comments are also welcome on the related PR (#10388 for EventDispatcherDebugCommand).

@matthieuauger matthieuauger changed the title Move debug commands to debug namespace [FrameworkBundle] [TwigBundle] Move debug commands to debug namespace Aug 12, 2014
@nicolas-grekas
Copy link
Member

Thank you @matthieuauger.

@nicolas-grekas nicolas-grekas merged commit fd0e229 into symfony:master Aug 13, 2014
nicolas-grekas added a commit that referenced this pull request Aug 13, 2014
…bug namespace (matthieuauger)

This PR was merged into the 2.6-dev branch.

Discussion
----------

[FrameworkBundle] [TwigBundle] Move debug commands to debug namespace

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT

Instead of having several namespaces with only one debug command (container:debug, event-dispatcher:debug), move all these debug commands to a new **debug** namespace.

Related to #10388 (comment)

I don't how to tag these aliases as deprecated as there are only here for backward compatibility.
The renaming should also be done in the Swiftmailer Bundle.

Commits
-------

fd0e229 Move debug commands to debug namespace
@matthieuauger matthieuauger deleted the feature/move-debug-commands-namespace branch August 14, 2014 13:06
matthieuauger pushed a commit to matthieuauger/symfony-docs that referenced this pull request Sep 7, 2014
matthieuauger pushed a commit to matthieuauger/symfony-docs that referenced this pull request Sep 8, 2014
matthieuauger pushed a commit to matthieuauger/symfony-docs that referenced this pull request Sep 8, 2014
matthieuauger pushed a commit to matthieuauger/symfony-docs that referenced this pull request Sep 8, 2014
weaverryan added a commit to symfony/symfony-docs that referenced this pull request Sep 18, 2014
This PR was merged into the master branch.

Discussion
----------

Move debug commands to debug namespace

Related to symfony/symfony#11627

Should we specify that it has been added in 2.6 and that backward compatibility is ensured ?

Commits
-------

d6dd540 Move debug command to the debug namespace
fabpot added a commit to symfony/swiftmailer-bundle that referenced this pull request Dec 1, 2014
This PR was merged into the 2.3-dev branch.

Discussion
----------

Move debug command to the debug namespace

Related to symfony/symfony#11627

Commits
-------

dee94b7 Move debug command to the debug namespace
@timglabisch
Copy link

shouldnt we mention this in the UPGRADE-3.0.md?

@fabpot
Copy link
Member
fabpot commented Dec 12, 2014

@timglabisch That makes sense.

xabbuh added a commit to xabbuh/symfony that referenced this pull request Dec 17, 2014
With symfony#11627, both the `ContainerDebugCommand` name and the
`ConfigDebugCommand` name have been moved to the `debug` namespace.
Thus, references should be updated accordingly.
xabbuh added a commit to xabbuh/symfony that referenced this pull request Dec 17, 2014
With symfony#11627, both the `ContainerDebugCommand` name and the
`ConfigDebugCommand` name have been moved to the `debug` namespace.
Thus, references should be updated accordingly.
fabpot added a commit that referenced this pull request Dec 17, 2014
…uh, aitboudad)

This PR was merged into the 2.6 branch.

Discussion
----------

[FrameworkBundle] update debug commands references

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #12939
| License       | MIT
| Doc PR        |

With #11627, both the `ContainerDebugCommand` name and the
`ConfigDebugCommand` name have been moved to the `debug` namespace.
Thus, references should be updated accordingly.

Commits
-------

c0925e4 [FrameworkBundle] Use debug namespace.
5847771 [FrameworkBundle] update debug commands references
fabpot added a commit that referenced this pull request May 21, 2015
…names to upgrade file (xabbuh)

This PR was merged into the 2.7 branch.

Discussion
----------

[FrameworkBundle][TwigBundle] add changed debug command names to upgrade file

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Thanks to @timglabisch for noticing this in #11627 (comment).

Commits
-------

4443c4d add changed debug command names to upgrade file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
0