8000 [FrameworkBundle] #9068 breaks knp paginator in dev environment · Issue #9089 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content
8000

[FrameworkBundle] #9068 breaks knp paginator in dev environment #9089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
smatyas opened this issue Sep 20, 2013 · 1 comment
Closed

[FrameworkBundle] #9068 breaks knp paginator in dev environment #9089

smatyas opened this issue Sep 20, 2013 · 1 comment

Comments

@smatyas
Copy link
Contributor
smatyas commented Sep 20, 2013

Modifications in @1843b820153 related to #9068 break knp paginator for me in the DEV environment, using 2.2.7-DEV.
Maybe it's related to service alias handling as it was in symfony/swiftmailer-bundle#44?
In the prod env. all works fine.

I get this exception:

        $itemsEvent->target = &$target;
        $this->eventDispatcher->dispatch('knp_pager.items', $itemsEvent);
        if (!$itemsEvent->isPropagationStopped()) {
            throw new \RuntimeException('One of listeners must count and slice given target');
        }
        // pagination initialization event
        $paginationEvent = new Event\PaginationEvent;
smatyas referenced this issue Sep 20, 2013
@fabpot
merged branch fabpot/event-dispatcher-debug (PR #9068)
1843b82 
This PR was merged into the 2.2 branch.

Discussion
----------

[FrameworkBundle] made sure that the debug event dispatcher is used everywhere

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #6686, #7673
| License       | MIT
| Doc PR        | n/a

Commits
-------

f65a526 [FrameworkBundle] made sure that the debug event dispatcher is used everywhere
@ghost ghost mentioned this issue Sep 20, 2013
Closed
@NG-iloWeb NG-iloWeb mentioned this issue Sep 21, 2013
Closed
@smatyas
Copy link
Contributor Author
smatyas commented Sep 23, 2013

Fixed in knplabs bundles:
KnpLabs/knp-components#88
KnpLabs/KnpPaginatorBundle#212

@smatyas smatyas closed this as completed Sep 23, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@smatyas
0