This repository was archived by the owner on Feb 6, 2022. It is now read-only.
fix checking of mailer services in EmailSenderListener #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return; | ||
| } | ||
| $mailers = array_keys($this->container->getParameter('swiftmailer.mailers')); | ||
| foreach ($mailers as $name) { | ||
| if ($this->container->initialized(sprintf('swiftmailer.mailer.%s', $name))) { | ||
| if ($this->container instanceof IntrospectableContainerInterface ? $this->container->initialized(sprintf('swiftmailer.mailer.%s', $name)) : $this->container->has(sprintf('swiftmailer.mailer.%s', $name))) { |
There was a problem hiding this comment.
$this->container->has(sprintf('swiftmailer.mailer.%s', $name)) is useless a useless condition: the container will always have it (as the swiftmailer.mailers parameter allows us to know what are the defined mailers)
There was a problem hiding this comment.
thanks, you're right!
smatyas
referenced
this pull request
in symfony/symfony
Sep 19, 2013
This PR was merged into the 2.2 branch. Discussion ---------- [FrameworkBundle] made sure that the debug event dispatcher is used everywhere | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #6686, #7673 | License | MIT | Doc PR | n/a Commits ------- f65a526 [FrameworkBundle] made sure that the debug event dispatcher is used everywhere
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'initialized' method of the Symfony\Component\DependencyInjection\Container does not handle aliases (as it is in the ContainerBuilder), but therefore the EmailSenderListener never sends emails.
This fix is related to issue #43.