8000 Fix sets event dispatcher (Error exists after sf update) by ZhukV · Pull Request #88 · KnpLabs/knp-components · GitHub
[go: up one dir, main page]
Skip to content

Fix sets event dispatcher (Error exists after sf update) #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 23, 2013
Merged

Fix sets event dispatcher (Error exists after sf update) #88

merged 2 commits into from
Sep 23, 2013

Conversation

ZhukV
Copy link
Contributor
@ZhukV ZhukV commented Sep 19, 2013

SF Updated: use \Symfony\Component\HttpKernel\Debug\TraceableEventDispatcher if use debug mode.

@pilot
Copy link
Contributor
pilot commented Sep 19, 2013

@ZhukV please update test also https://travis-ci.org/KnpLabs/knp-components/jobs/11546520

@ZhukV
Copy link
Contributor Author
ZhukV commented Sep 19, 2013

I fixed this bug (I not see auto create EventDispatcher in constructor and remove EventDispatcher class from "use" statement), but component have a another error, which are not related to this error.

Thank.

@ZhukV
Copy link
Contributor Author
ZhukV commented Sep 21, 2013

ping

@ZhukV
Copy link
Contributor Author
ZhukV commented Sep 23, 2013

ping.

Catchable Fatal Error: Argument 1 passed to Knp\Component\Pager\Paginator::__construct() must be an instance of Symfony\Component\EventDispatcher\EventDispatcher, instance of Symfony\Component\HttpKernel\Debug\TraceableEventDispatcher given, called in /..../app/cache/dev/appDevDebugProjectContainer.php on line 2112 and defined in ...//vendor/knplabs/knp-components/src/Knp/Component/Pager/Paginator.php line 45

Why not merge this commit?

pilot added a commit that referenced this pull request Sep 23, 2013
@pilot
Merge pull request #88 from ZhukV/master
71ae73c 
Fix sets event dispatcher (Error exists after sf update)
@pilot pilot merged commit 71ae73c into KnpLabs:master Sep 23, 2013
@smatyas smatyas mentioned this pull request Sep 23, 2013
Closed
This was referenced Nov 5, 2013
Closed
Closed
Closed
@tkleinhakisa tkleinhakisa mentioned this pull request Jan 9, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZhukV @pilot @Seldaek
0