[DependencyInjection] ContainerBuilder::getReflectionClass() does not support interfaces, if symfony/config package not present #58821
Comments
|
Currently, the code in question is not even covered by tests. At least not any test in the github actions. See I think the problem here is that all the tests run in the full monorepo, which means that If we want to add tests for this, we need to rethink overall how we run tests in symfony. |
donquixote
added a commit
to donquixote/symfony
that referenced
this issue
Nov 10, 2024
…ainerBuilder::getReflectionClass().
donquixote
added a commit
to donquixote/symfony
that referenced
this issue
Nov 10, 2024
nicolas-grekas
pushed a commit
to donquixote/symfony
that referenced
this issue
Nov 20, 2024
…ainerBuilder::getReflectionClass().
nicolas-grekas
added a commit
that referenced
this issue
Nov 20, 2024
…inerBuilder::getReflectionClass() (donquixote) This PR was merged into the 5.4 branch. Discussion ---------- [DependencyInjection] Fix checking for interfaces in ContainerBuilder::getReflectionClass() | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #58821. | License | MIT Currently, `ContainerBuilder::getReflectionClass()` supports interfaces only if `symfony/config` package is present. With this fix, it will do so without `symfony/config`. > Always add tests and ensure they pass. Not sure how to do this. All tests run in the monorepo, with all packages present, so `class_exists(ClassExistenceResource::class)` will always be TRUE. To make this testable, we should make the condition dependent on resource tracking. > Never break backward compatibility (see https://symfony.com/bc). This is TBD. This change would enable autowire for some services where this was previously not the case. Commits ------- 6166e8f Issue #58821: [DependencyInjection] Support interfaces in ContainerBuilder::getReflectionClass().
nicolas-grekas
added a commit
that referenced
this issue
Nov 20, 2024
* 5.4: Issue #58821: [DependencyInjection] Support interfaces in ContainerBuilder::getReflectionClass(). Dynamically fix compatibility with doctrine/data-fixtures v2 [HttpKernel] Ensure HttpCache::getTraceKey() does not throw exception don't call EntityManager::initializeObject() with scalar values [Validator] review italian translations Update PR template
nicolas-grekas
added a commit
that referenced
this issue
Nov 20, 2024
* 6.4: fix: ignore missing directory in isVendor() [OptionsResolver] Allow Union/Intersection Types in Resolved Closures Issue #58821: [DependencyInjection] Support interfaces in ContainerBuilder::getReflectionClass(). Dynamically fix compatibility with doctrine/data-fixtures v2 [HttpKernel] Ensure HttpCache::getTraceKey() does not throw exception don't call EntityManager::initializeObject() with scalar values [Validator] review italian translations Update PR template
nicolas-grekas
added a commit
that referenced
this issue
Nov 20, 2024
* 7.1: fix: ignore missing directory in isVendor() [OptionsResolver] Allow Union/Intersection Types in Resolved Closures Issue #58821: [DependencyInjection] Support interfaces in ContainerBuilder::getReflectionClass(). Dynamically fix compatibility with doctrine/data-fixtures v2 [HttpKernel] Ensure HttpCache::getTraceKey() does not throw exception don't call EntityManager::initializeObject() with scalar values make RelayProxyTrait compatible with relay extension 0.9.0 [Validator] review italian translations Update PR template
nicolas-grekas
added a commit
that referenced
this issue
Nov 20, 2024
* 7.2: Revert "bug #58937 [FrameworkBundle] Don't auto-register form/csrf when the corresponding components are not installed (nicolas-grekas)" Fix merge fix: ignore missing directory in isVendor() [OptionsResolver] Allow Union/Intersection Types in Resolved Closures Issue #58821: [DependencyInjection] Support interfaces in ContainerBuilder::getRef 62CB lectionClass(). Dynamically fix compatibility with doctrine/data-fixtures v2 [HttpKernel] Ensure HttpCache::getTraceKey() does not throw exception don't call EntityManager::initializeObject() with scalar values [FrameworkBundle] Don't auto-register form/csrf when the corresponding components are not installed make RelayProxyTrait compatible with relay extension 0.9.0 [Validator] review italian translations Update PR template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Symfony version(s) affected
7.2.0
Description
The ContainerBuilder::getReflectionClass() method does not support interfaces when 'symfony/config' package not present.
Given an interface
MyInterface..With symfony/config package present,
$builder->getReflectionClass(MyInterface::class)will return a\ReflectionClassobject for that interface.With symfony/config package missing,
$builder->getReflectionClass(MyInterface::class)will returnfalse.This has an impact on
AutowirePass, if the class on a service definition is an interface.How to reproduce
This problem manifests in two levels.
Low-level manifestation
Higher level manifestation in autowire
Possible Solution
In
ContainerBuilder::getReflectionClass(), add a|| interface_exists($class)`.Additional Context
No response
The text was updated successfully, but these errors were encountered: