bug #58822 [DependencyInjection] Fix checking for interfaces in ContainerBuilder::getReflectionClass() (donquixote)

nicolas-grekas · nicolas-grekas · commit cf20e0931427 · 2024-11-20T11:52:04.000+01:00
This PR was merged into the 5.4 branch. Discussion ---------- [DependencyInjection] Fix checking for interfaces in ContainerBuilder::getReflectionClass() | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #58821. | License | MIT Currently, `ContainerBuilder::getReflectionClass()` supports interfaces only if `symfony/config` package is present. With this fix, it will do so without `symfony/config`. > Always add tests and ensure they pass. Not sure how to do this. All tests run in the monorepo, with all packages present, so `class_exists(ClassExistenceResource::class)` will always be TRUE. To make this testable, we should make the condition dependent on resource tracking. > Never break backward compatibility (see https://symfony.com/bc). This is TBD. This change would enable autowire for some services where this was previously not the case. Commits ------- 6166e8f Issue #58821: [DependencyInjection] Support interfaces in ContainerBuilder::getReflectionClass().
diff --git a/src/Symfony/Component/DependencyInjection/ContainerBuilder.php b/src/Symfony/Component/DependencyInjection/ContainerBuilder.php
@@ -369,7 +369,7 @@ public function getReflectionClass(?string $class, bool $throw = true): ?\Reflec
                 $resource = new ClassExistenceResource($class, false);
                 $classReflector = $resource->isFresh(0) ? false : new \ReflectionClass($class);
             } else {
-                $classReflector = class_exists($class) ? new \ReflectionClass($class) : false;
+                $classReflector = class_exists($class) || interface_exists($class, false) ? new \ReflectionClass($class) : false;
             }
         } catch (\ReflectionException $e) {
             if ($throw) {

Original file line number	Diff line number	Diff line change
`@@ -369,7 +369,7 @@ public function getReflectionClass(?string $class, bool $throw = true): ?\Reflec`
`369`	`369`	`$resource = new ClassExistenceResource($class, false);`
`370`	`370`	`$classReflector = $resource->isFresh(0) ? false : new \ReflectionClass($class);`
`371`	`371`	`} else {`
`372`		`- $classReflector = class_exists($class) ? new \ReflectionClass($class) : false;`
	`372`	`+ $classReflector = class_exists($class) \|\| interface_exists($class, false) ? new \ReflectionClass($class) : false;`
`373`	`373`	`}`
`374`	`374`	`} catch (\ReflectionException $e) {`
`375`	`375`	`if ($throw) {`