8000 Console completion: Error message is not accurate when failed to guess shell · Issue #48171 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Console completion: Error message is not accurate when failed to guess shell #48171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Chi-teck opened this issue Nov 9, 2022 · 0 comments
Closed

Console completion: Error message is not accurate when failed to guess shell #48171

Chi-teck opened this issue Nov 9, 2022 · 0 comments
Labels
Bug Console Status: Needs Review

Comments

@Chi-teck
Copy link
Contributor
Chi-teck commented Nov 9, 2022 •
edited
Loading

Symfony version(s) affected

6.2.0

Description

On my environment the $_SERVER['SHELL'] is not set by some reason.
When I run console completion the following error message shows up.

Detected shell "", which is not supported by Symfony shell completion (supported shells: "bash", "fish", "zsh").

How to reproduce

console completion ''

Possible Solution

Change wording for the case when SHELL has not been guessed.

Additional Context

No response
@Chi-teck Chi-teck added the Bug label Nov 9, 2022
@GromNaN GromNaN mentioned this issue Nov 15, 2022
Merged
@fabpot fabpot closed this as completed Nov 19, 2022
fabpot added a commit that referenced this issue Nov 19, 2022
@fabpot
bug #48217 [Console] Improve error message when shell is not detected…
d4fab7f 
… in completion command (GromNaN)

This PR was merged into the 5.4 branch.

Discussion
----------

[Console] Improve error message when shell is not detected in completion command

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?     
551D
 | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #48171
| License       | MIT

Commits
-------

7534fb1 Improve message when shell is not detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Console Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fabpot @Chi-teck @derrabus @carsonbot
0