8000 Improve message when shell is not detected · symfony/symfony@7534fb1 · GitHub
[go: up one dir, main page]

Skip to content

Commit 7534fb1

Browse files
committed
Improve message when shell is not detected
1 parent 38b0c19 commit 7534fb1

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

src/Symfony/Component/Console/Command/DumpCompletionCommand.php

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,14 @@ protected function execute(InputInterface $input, OutputInterface $output): int
9393
if (!file_exists($completionFile)) {
9494
$supportedShells = $this->getSupportedShells();
9595

96-
($output instanceof ConsoleOutputInterface ? $output->getErrorOutput() : $output)
97-
->writeln(sprintf('<error>Detected shell "%s", which is not supported by Symfony shell completion (supported shells: "%s").</>', $shell, implode('", "', $supportedShells)));
96+
if ($output instanceof ConsoleOutputInterface) {
97+
$output = $output->getErrorOutput();
98+
}
99+
if ($shell) {
100+
$output->writeln(sprintf('<error>Detected shell "%s", which is not supported by Symfony shell completion (supported shells: "%s").</>', $shell, implode('", "', $supportedShells)));
101+
} else {
102+
$output->writeln(sprintf('<error>Shell not detected, Symfony shell completion only supports "%s").</>', implode('", "', $supportedShells)));
103+
}
98104

99105
return self::INVALID;
100106
}

0 commit comments

Comments
 (0)
0