8000 Missing translations for Norwegian Nynorsk (nn) · Issue #38756 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content
8000

Missing translations for Norwegian Nynorsk (nn) #38756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Nyholm opened this issue Oct 25, 2020 · 9 comments
Closed

Missing translations for Norwegian Nynorsk (nn) #38756

Nyholm opened this issue Oct 25, 2020 · 9 comments
Labels
Good first issue Ideal for your first contribution! (some Symfony experience may be required) Help wanted Issues and PRs which are looking for volunteers to complete them. Missing translations
Milestone

Comments

@Nyholm
Copy link
Member
Nyholm commented Oct 25, 2020

Hello,

There are some missing translation for Norwegian Nynorsk (nn). These should be added in branch 4.4.
See #38710 for details and this page for an example.

These are the files that should be updated:

NOTE: If you want to work on this issue, add a comment to assign it to yourself and let others know that this is already taken.

@Nyholm Nyholm added Good first issue Ideal for your first contribution! (some Symfony experience may be required) Help wanted Issues and PRs which are looking for volunteers to complete them. Missing translations labels Oct 25, 2020
@derrabus derrabus added this to the 3.4 milestone Oct 26, 2020
@fabpot fabpot modified the milestones: 3.4, 4.4 Oct 28, 2020
@Nyholm
Copy link
Member Author
Nyholm commented Oct 30, 2020

Ping @themilanfan, There is already Bokmål added, could you have a look at the Nynorsk?

@Nyholm
Copy link
Member Author
Nyholm commented Dec 7, 2020

Or maybe @glye is around to help out again?

@glye
Copy link
Contributor
glye commented Dec 7, 2020

@Nyholm I've done this before? Hm, git confirms. Okay :) How urgent is it?
NB: I'm a native Norwegian speaker, but not a native Nynorsk writer. I can do a semi-decent job, but if there's a native writer here, it would be good of you to step in.

@Nyholm
Copy link
Member Author
Nyholm commented Dec 7, 2020

=)

If you do a first attempt that would be great. I'll see if I can find some other native to confirm the work.

It is not urgent, it is open source =). Sooner the better of course, but life always comes first.

@Nyholm
Copy link
Member Author
Nyholm commented Mar 7, 2021

@glye did you have time to have a look at this?

@glye
Copy link
Contributor
glye commented Mar 10, 2021

Sorry, not yet, and sorry about the late reply. Do you have an idea about how many strings are missing? Is the procedure still to check out the English file and manually copy over missing parts, then translate?

@Nyholm
Copy link
Member Author
Nyholm commented Mar 10, 2021

Do you have an idea about how many strings are missing?

It is about 30-40 strings. Most of them are similar to "Please enter a valid week".

Is the procedure still to check out the English file and manually copy over missing parts, then translate?

Yes, pretty much.
I have a small example of the procedure you described at https://symfony-translations.nyholm.tech/#pr

@glye
Copy link
Contributor
glye commented Mar 10, 2021

Thanks, that's not much. I'll get it done.

@glye
Copy link
Contributor
glye commented Mar 10, 2021

PR: #40435
One failing test so far, which is nothing to do with this.

fabpot pushed a commit to glye/symfony that referenced this issue Mar 10, 2021
fabpot added a commit that referenced this issue Mar 10, 2021
…unnstein Lye)

This PR was squashed before being merged into the 4.4 branch.

Discussion
----------

Update translations for Norwegian Nynorsk (nn) #38756

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #38756
| License       | MIT
| Doc PR        | n/a

Fix #38756 - Add missing Nynorsk translations, and improve existing ones.

Commits
-------

9a4a046 Update translations for Norwegian Nynorsk (nn) #38756
@fabpot fabpot closed this as completed Mar 10, 2021
derrabus added a commit that referenced this issue Mar 10, 2021
* 4.4:
  Update translations for Norwegian Nynorsk (nn) #38756
  Fix eventListener initialization when eventSubscriber constructor dispatch an event
  clear unchecked choice radio boxes even if clear missing is set to false
  [ErrorHandler] Added missing type annotations to FlattenException
  [TwigBridge] Allow version 3 of the Twig extra packages
  Fix FrameworkBundle PropertyAccess definition when not in debug
derrabus added a commit that referenced this issue Mar 10, 2021
* 5.2:
  Bump Symfony version to 5.2.6
  Update VERSION for 5.2.5
  Update CHANGELOG for 5.2.5
  Update translations for Norwegian Nynorsk (nn) #38756
  Fix eventListener initialization when eventSubscriber constructor dispatch an event
  [FrameworkBundle] fix XSD
  clear unchecked choice radio boxes even if clear missing is set to false
  Fix `ConstraintViolation#getPropertyPath()` to always return `string`
  [ErrorHandler] Added missing type annotations to FlattenException
  [TwigBridge] Allow version 3 of the Twig extra packages
  Fix FrameworkBundle PropertyAccess definition when not in debug
PhilETaylor pushed a commit to PhilETaylor/symfony that referenced this issue Sep 6, 2023
* 4.4:
  Update translations for Norwegian Nynorsk (nn) symfony#38756
  Fix eventListener initialization when eventSubscriber constructor dispatch an event
  clear unchecked choice radio boxes even if clear missing is set to false
  [ErrorHandler] Added missing type annotations to FlattenException
  [TwigBridge] Allow version 3 of the Twig extra packages
  Fix FrameworkBundle PropertyAccess definition when not in debug
PhilETaylor pushed a commit to PhilETaylor/symfony that referenced this issue Sep 6, 2023
* 5.2:
  Bump Symfony version to 5.2.6
  Update VERSION for 5.2.5
  Update CHANGELOG for 5.2.5
  Update translations for Norwegian Nynorsk (nn) symfony#38756
  Fix eventListener initialization when eventSubscriber constructor dispatch an event
  [FrameworkBundle] fix XSD
  clear unchecked choice radio boxes even if clear missing is set to false
  Fix `ConstraintViolation#getPropertyPath()` to always return `string`
  [ErrorHandler] Added missing type annotations to FlattenException
  [TwigBridge] Allow version 3 of the Twig extra packages
  Fix FrameworkBundle PropertyAccess definition when not in debug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue Ideal for your first contribution! (some Symfony experience may be required) Help wanted Issues and PRs which are looking for volunteers to complete them. Missing translations
Projects
None yet
Development

No branches or pull requests

4 participants
0