10000 [DoctrineBridge] Remove RegistryInterface · Issue #32394 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[DoctrineBridge] Remove RegistryInterface #32394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
derrabus opened this issue Jul 5, 2019 · 1 comment
Closed

[DoctrineBridge] Remove RegistryInterface #32394

derrabus opened this issue Jul 5, 2019 · 1 comment
Labels
Deprecation DoctrineBridge
Milestone
4.4

Comments

@derrabus
Copy link
Member
derrabus commented Jul 5, 2019

The doctrine bridge contains the interface Symfony\Bridge\Doctrine\RegistryInterface.

  • The only implementation of that interface that I know of is Doctrine\Bundle\DoctrineBundle\Registry which has been triggering deprecation errors for each method defined by the interface for 6.5 years now: doctrine/DoctrineBundle@89c7e14

  • Its parent interface Doctrine\Common\Persistence\ManagerRegistry is an equal replacement.

  • I haven't found a single reference to the interface in the symfony codebase (except for the one I've removed in [Messenger] Use ConnectionRegistry instead of RegistryInterface #32354).

I find the very existence of this interface highly confusing and suggest to deprecate the interface in 4.4 and remove it with Symfony 5.
@javiereguiluz javiereguiluz added this to the next milestone Jul 5, 2019
@fabpot
Copy link
Member
fabpot commented Jul 8, 2019

Let's do it!

@Koc Koc mentioned this issue Jul 30, 2019
Merged
Tobion added a commit that referenced this issue Aug 1, 2019
@Tobion
feature #32817 [DoctrineBridge] Deprecate RegistryInterface (Koc)
bb74384 
This PR was merged into the 4.4 branch.

Discussion
----------

[DoctrineBridge] Deprecate RegistryInterface

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yno
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | #32394
| License       | MIT
| Doc PR        | -

Commits
-------

151415b [DoctrineBridge] Deprecated RegistryInterface
@Koc Koc mentioned this issue Aug 1, 2019
Merged
Koc added a commit to Koc/symfony that referenced this issue Aug 1, 2019
@Koc
[DoctrineBridge] Removed RegistryInterface (closes symfony#32394)
ad1dd6c
Tobion added a commit that referenced this issue Aug 2, 2019
@Tobion
minor #32876 [DoctrineBridge] Removed RegistryInterface (Koc)
ccf747b 
This PR was merged into the 5.0-dev branch.

Discussion
----------

[DoctrineBridge] Removed RegistryInterface

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #32394
| License       | MIT
| Doc PR        | -

Follow up of #32817

Commits
-------

ad1dd6c [DoctrineBridge] Removed RegistryInterface (closes #32394)
@Tobion Tobion closed this as completed Aug 2, 2019
m-vo pushed a commit to m-vo/symfony that referenced this issue Sep 20, 2019
@Koc @m-vo
[DoctrineBridge] Removed RegistryInterface (closes symfony#32394)
28c2c8a
m-vo pushed a commit to m-vo/symfony that referenced this issue Sep 20, 2019
@Koc @m-vo
[DoctrineBridge] Removed RegistryInterface (closes symfony#32394)
36d54c2
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.4 Oct 27, 2019
@Matts Matts mentioned this issue Nov 14, 2019
Closed
@maxwellmc maxwellmc mentioned this issue Nov 21, 2019
Merged
@ctrl-f5 ctrl-f5 mentioned this issue Nov 22, 2019
Closed
@crabnky crabnky mentioned this issue Dec 3, 2019
Closed
@romaricdrigon romaricdrigon mentioned this issue Dec 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Deprecation DoctrineBridge
Projects
None yet
Milestone
4.4
Development

No branches or pull requests
5 participants
@fabpot @javiereguiluz @nicolas-grekas @Tobion @derrabus
0