feature #32817 [DoctrineBridge] Deprecate RegistryInterface (Koc)

Tobion · Tobion · commit bb743842364a · 2019-08-01T20:52:08.000+02:00
This PR was merged into the 4.4 branch. Discussion ---------- [DoctrineBridge] Deprecate RegistryInterface | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yno | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #32394 | License | MIT | Doc PR | - Commits ------- 151415b [DoctrineBridge] Deprecated RegistryInterface
diff --git a/UPGRADE-4.4.md b/UPGRADE-4.4.md
@@ -63,6 +63,14 @@ DependencyInjection
    ```php
    new Definition('%my_class%');
    ```
+   
+DoctrineBridge
+--------------
+ * Deprecated injecting `ClassMetadataFactory` in `DoctrineExtractor`, an instance of `EntityManagerInterface` should be
+   injected instead.
+ * Deprecated passing an `IdReader` to the `DoctrineChoiceLoader` when the query cannot be optimized with single id field.
+ * Deprecated not passing an `IdReader` to the `DoctrineChoiceLoader` when the query can be optimized with single id field.
+ * Deprecated `RegistryInterface`, use `Doctrine\Common\Persistence\ManagerRegistry`.
 
 Filesystem
 ----------
diff --git a/UPGRADE-5.0.md b/UPGRADE-5.0.md
@@ -115,10 +115,11 @@ DependencyInjection
 DoctrineBridge
 --------------
 
- * Deprecated injecting `ClassMetadataFactory` in `DoctrineExtractor`, an instance of `EntityManagerInterface` should be
+ * Removed the possibility to inject `ClassMetadataFactory` in `DoctrineExtractor`, an instance of `EntityManagerInterface` should be
    injected instead
  * Passing an `IdReader` to the `DoctrineChoiceLoader` when the query cannot be optimized with single id field will throw an exception, pass `null` instead
  * Not passing an `IdReader` to the `DoctrineChoiceLoader` when the query can be optimized with single id field will not apply any optimization
+ * The `RegistryInterface` has been removed.
 
 DomCrawler
 ----------
diff --git a/src/Symfony/Bridge/Doctrine/CHANGELOG.md b/src/Symfony/Bridge/Doctrine/CHANGELOG.md
@@ -5,6 +5,7 @@ CHANGELOG
 -----
 
  * added `DoctrineClearEntityManagerMiddleware`
+ * deprecated `RegistryInterface`, use `Doctrine\Common\Persistence\ManagerRegistry`
 
 
 4.3.0
diff --git a/src/Symfony/Bridge/Doctrine/RegistryInterface.php b/src/Symfony/Bridge/Doctrine/RegistryInterface.php
@@ -17,6 +17,8 @@
 /**
  * References Doctrine connections and entity managers.
  *
+ * @deprecated since Symfony 4.4, use Doctrine\Common\Persistence\ManagerRegistry instead
+ *
  * @author Fabien Potencier <fabien@symfony.com>
  */
 interface RegistryInterface extends ManagerRegistryInterface

Original file line number	Diff line number	Diff line change
`@@ -17,6 +17,8 @@`
`17`	`17`	`/**`
`18`	`18`	`* References Doctrine connections and entity managers.`
`19`	`19`	`*`
	`20`	`+ * @deprecated since Symfony 4.4, use Doctrine\Common\Persistence\ManagerRegistry instead`
	`21`	`+ *`
`20`	`22`	`* @author Fabien Potencier <fabien@symfony.com>`
`21`	`23`	`*/`
`22`	`24`	`interface RegistryInterface extends ManagerRegistryInterface`