8000 [Translation] Add name attribute to XLIFF 2.0 · Issue #25758 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Translation] Add name attribute to XLIFF 2.0 #25758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
timwhitlock opened this issue Jan 10, 2018 · 0 comments
Closed

[Translation] Add name attribute to XLIFF 2.0 #25758

timwhitlock opened this issue Jan 10, 2018 · 0 comments
Labels
Feature Translation

Comments

@timwhitlock
Copy link
Q A
Bug report? no
Feature request? yes
BC Break report? no
RFC? no
Symfony version 4.0.3

For XLIFF 1.2 the XliffFileDumper correctly adds translation keys into the resname attribute, but does not populate the equivalent name attribute for XLIFF 2.0.

Although optional, the specification describes this as:

The original identifier of the resource corresponding to the Extracted <unit> or <group>.

For example: the key in the key/value pair in a Java properties file, the ID of a string in a Windows string table, the index value of an entry in a database table, etc.

For backward compatibility I don't expect to see a change to the way the <source> element is used, but for the 1.2 and 2.0 formats to be treated as equivalent it seems the same logic should be applied.
@Nyholm Nyholm mentioned this issue Feb 12, 2018
Closed
@fabpot fabpot closed this as completed Feb 15, 2018
fabpot added a commit that referenced this issue Feb 15, 2018
@fabpot
feature #26149 Added support for name on the unit node (Nyholm)
b0facfe 
This PR was squashed before being merged into the 4.1-dev branch (closes #26149).

Discussion
----------

Added support for name on the unit node

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #25758
| License       | MIT
| Doc PR        | na

See [unit specification](http://docs.oasis-open.org/xliff/xliff-core/v2.0/os/xliff-core-v2.0-os.html#unit) and [name specification](http://docs.oasis-open.org/xliff/xliff-core/v2.0/os/xliff-core-v2.0-os.html#name)

Commits
-------

30a22aa Added support for name on the unit node
@Nyholm Nyholm mentioned this issue Feb 20, 2018
Merged
@Nyholm Nyholm mentioned this issue Mar 27, 2018
Merged
@timwhitlock timwhitlock mentioned this issue Apr 10, 2018
Open
@pontus-mp pontus-mp mentioned this issue Jun 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Translation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fabpot @timwhitlock @xabbuh
0