Added the name attribute to XLIFF 2 documents #9302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That is a super valid comment. From symfony/symfony#25758
So my answer is simply just: "but we do it in 1.2, that is why I do it in 2.0". Im not sure what the reasoning were back when 1.2 was made. Im also not sure what would be a good value if the Maybe one could improve the name by somehow slugify and shorten the |
|
I see, it's because of BC compatibility. Thanks! Maybe we could use: |
|
I would rather do something like: $name = $source;
if (strlen($source) > 80)) {
$name = substr(md5($source), -7); // Why "-7" btw?
} |
|
The |
|
Let's merge this "as is" and if we need to change anything in the code, let's discuss about that in a separate issue. Thanks! |
javiereguiluz
added a commit
that referenced
this pull request
Feb 21, 2018
…luz) This PR was merged into the master branch. Discussion ---------- Added the name attribute to XLIFF 2 documents This fixes #9287. It's a simple fix because we only display one XLIFF 2 document in the docs. ----- @Nyholm I'm sure you did the right thing ... but just asking: making the `name` value the same as `source` is the best possible solution here? In Symfony's code the `source` attribute is short (https://github.com/symfony/symfony/pull/26149/files) but in real world it can be super long and super ugly (containing `CDATA`, etc.) So, don't you think this will be very verbose? Could we make the `name` value the same as the `id` attribute instead? If the XLIFF standard forces us to do this, then forget my comment and accept my apologies 😄 Commits ------- 30ee49e Added the name attribute to XLIFF 2 documents
symfony-splitter
pushed a commit
to symfony/translation
that referenced
this pull request
Mar 30, 2018
…o long for "name" (Nyholm) This PR was merged into the 4.1-dev branch. Discussion ---------- [Translation] XLIFF2: Make sure to trim source if it is too long for "name" | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | This PR is a follow-up on @javiereguiluz's comment here: symfony/symfony-docs#9302 This feature was introduced in symfony/symfony#26149 Commits ------- ca41fecfd9 Make sure to trim source if it is too long
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Mar 30, 2018
…o long for "name" (Nyholm) This PR was merged into the 4.1-dev branch. Discussion ---------- [Translation] XLIFF2: Make sure to trim source if it is too long for "name" | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | This PR is a follow-up on @javiereguiluz's comment here: symfony/symfony-docs#9302 This feature was introduced in #26149 Commits ------- ca41fec Make sure to trim source if it is too long
SerhiyMytrovtsiy
added a commit
to SerhiyMytrovtsiy/translation
that referenced
this pull request
Oct 19, 2022
…o long for "name" (Nyholm) This PR was merged into the 4.1-dev branch. Discussion ---------- [Translation] XLIFF2: Make sure to trim source if it is too long for "name" | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | This PR is a follow-up on @javiereguiluz's comment here: symfony/symfony-docs#9302 This feature was introduced in symfony/symfony#26149 Commits ------- ca41fecfd9 Make sure to trim source if it is too long
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #9287. It's a simple fix because we only display one XLIFF 2 document in the docs.
@Nyholm I'm sure you did the right thing ... but just asking: making the
namevalue the same assourceis the best possible solution here? In Symfony's code thesourceattribute is short (https://github.com/symfony/symfony/pull/26149/files) but in real world it can be super long and super ugly (containingCDATA, etc.) So, don't you think this will be very verbose? Could we make thenamevalue the same as theidattribute instead? If the XLIFF standard forces us to do this, then forget my comment and accept my apologies 😄