8000 assets:install removing bundle directories · Issue #23416 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

assets:install removing bundle directories #23416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bmadzar opened this issue Jul 5, 2017 · 8 comments
Closed

assets:install removing bundle directories #23416

bmadzar opened this issue Jul 5, 2017 · 8 comments
Labels
Asset BC Break Bug FrameworkBundle Status: Needs Review

Comments

@bmadzar
Copy link
bmadzar commented Jul 5, 2017
Q A
Bug report? yes
Feature request? no
BC Break report? yes
RFC? no
Symfony version 3.2.11

The change introduced in 3.2.10 (#23195) broke our applications.

We have several Symfony applications that share a web/bundles dir. Previously they could coexist happily but now running assets:install on one deletes the assets from the others. #23378 does not fix the problem, we basically need assets:install to ignore bundles it doesn't know about.

This sort of breaking change should not be introduced in a patch version.
@bmadzar bmadzar changed the title assets:install removing bundle directories assets:install removing bundle directories Jul 5, 2017
@1ed
Copy link
Contributor
1ed commented Jul 5, 2017 •
edited
Loading

Already fixed in #23378 and 3.2.11 was released.

@bmadzar
Copy link
Author
bmadzar commented Jul 5, 2017

@1ed I have tried 3.2.11 and the problem exists there as well. My understanding of #23378 is that it only fixes the problem for files, not directories.

@stof
Copy link
Member
stof commented Jul 5, 2017

@1ed I don't think the PR you mentionned fixes the case reported here.

@bmadzar the previous behavior was considered as bug, as it would leave broken files around (symlinks pointing to a removed folder for instance). This is why it happened in a patch release.
What is your use case for several applications sharing the same web/bundles folder ? And is it for applications sharing the same vendor folder or no ?

@1ed
Copy link
Contributor
1ed commented Jul 5, 2017

Oh, yes. Sorry I didn't read it through carefully.

@bmadzar
Copy link
Author
bmadzar commented Jul 5, 2017

@stof Yes, the applications share the same vendor folder as well. We only have a single public directory on the server.

@tristanbes
Copy link
Contributor
tristanbes commented Jul 24, 2017 •
edited
Loading

It's a major bc break for us we just discovered this after upgrading to 3.3
We also have 2 kernels. All assets were published in the same folder.

So we run
./sitecon assets:install --smylink web/ for kernel A
./admincon assets:install --symlink web/ for kernel B

Now, if we run command for A then B only assets from Kernel B are present breaking the application using the kernel A

We are fixing it in an urgent matter updating all paths inside our database and twig files so we get them in 2 separate folders, but this definitly should be treated as a BC break and warn users about it.

PS: we use same vendor/ folder, just 2 kernels and 2 config dirs to answer @stof question.

@mvrhov
Copy link
mvrhov commented Jul 25, 2017

This is probably also broken for one of our sites if we decide to migrate. As we also have the same setup as @tristanbes

@jakzal jakzal mentioned this issue Oct 25, 2017
Closed
@nicolas-grekas
Copy link
Member

See #24216 (comment)
Someone needs to take over if anything should be done.

@robinlehrmann robinlehrmann mentioned this issue Oct 25, 2017
Merged
fabpot added a commit that referenced this issue Dec 7, 2017
@fabpot
feature #24216 added clean option to assets install command (robinleh…
d220e28 
…rmann)

This PR was merged into the 4.1-dev branch.

Discussion
----------

added clean option to assets install command

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #24204, #23416
| License       | MIT

Commits
-------

771f11b added clean option to assets install command
@fabpot fabpot closed this as completed Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Asset BC Break Bug FrameworkBundle Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
10 participants
@fabpot @1ed @jakzal @nicolas-grekas @tristanbes @stof @mvrhov @bmadzar @xabbuh @carsonbot
2A88
0