feature #24216 added clean option to assets install command (robinlehrmann)

fabpot · fabpot · commit d220e28a9909 · 2017-12-07T08:16:48.000-08:00
This PR was merged into the 4.1-dev branch. Discussion ---------- added clean option to assets install command | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #24204, #23416 | License | MIT Commits ------- 771f11b added clean option to assets install command
diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/AssetsInstallCommand.php b/src/Symfony/Bundle/FrameworkBundle/Command/AssetsInstallCommand.php
@@ -58,6 +58,7 @@ protected function configure()
             ))
             ->addOption('symlink', null, InputOption::VALUE_NONE, 'Symlinks the assets instead of copying it')
             ->addOption('relative', null, InputOption::VALUE_NONE, 'Make relative symlinks')
+            ->addOption('no-cleanup', null, InputOption::VALUE_NONE, 'Do not remove the assets of the bundles that no longer exist')
             ->setDescription('Installs bundles web assets under a public directory')
             ->setHelp(<<<'EOT'
 The <info>%command.name%</info> command installs bundle assets into a given
@@ -162,7 +163,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
             }
         }
         // remove the assets of the bundles that no longer exist
-        if (is_dir($bundlesDir)) {
+        if (!$input->getOption('no-cleanup') && is_dir($bundlesDir)) {
             $dirsToRemove = Finder::create()->depth(0)->directories()->exclude($validAssetDirs)->in($bundlesDir);
             $this->filesystem->remove($dirsToRemove);
         }

Original file line number	Diff line number	Diff line change
`@@ -58,6 +58,7 @@ protected function configure()`
`58`	`58`	`))`
`59`	`59`	`->addOption('symlink', null, InputOption::VALUE_NONE, 'Symlinks the assets instead of copying it')`
`60`	`60`	`->addOption('relative', null, InputOption::VALUE_NONE, 'Make relative symlinks')`
	`61`	`+ ->addOption('no-cleanup', null, InputOption::VALUE_NONE, 'Do not remove the assets of the bundles that no longer exist')`
`61`	`62`	`->setDescription('Installs bundles web assets under a public directory')`
`62`	`63`	`->setHelp(<<<'EOT'`
`63`	`64`	`The <info>%command.name%</info> command installs bundle assets into a given`
`@@ -162,7 +163,7 @@ protected function execute(InputInterface $input, OutputInterface $output)`
`162`	`163`	`}`
`163`	`164`	`}`
`164`	`165`	`// remove the assets of the bundles that no longer exist`
`165`		`- if (is_dir($bundlesDir)) {`
	`166`	`+ if (!$input->getOption('no-cleanup') && is_dir($bundlesDir)) {`
`166`	`167`	`$dirsToRemove = Finder::create()->depth(0)->directories()->exclude($validAssetDirs)->in($bundlesDir);`
`167`	`168`	`$this->filesystem->remove($dirsToRemove);`
`168`	`169`	`}`