8000 [3.2][Validation] New ValidationCacheWarmer incorrectly handles empty validation.yml · Issue #20761 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[3.2][Validation] New ValidationCacheWarmer incorrectly handles empty validation.yml #20761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lbayerl opened this issue Dec 5, 2016 · 0 comments
Closed

[3.2][Validation] New ValidationCacheWarmer incorrectly handles empty validation.yml #20761

lbayerl opened this issue Dec 5, 2016 · 0 comments
Labels
Bug Status: Needs Review Validator

Comments

@lbayerl
Copy link
lbayerl commented Dec 5, 2016 •
edited
Loading

As were using annotations for our validation meta data we don't use yaml validation definitions.
But we still have an empty validation.yml in OurBundle/Resources/config/ - this wasn't an issue until Symfony 3.2.

But obviously with the new ValidationCacheWarmer this file is being parsed and to be merged with other validations here:

symfony/src/Symfony/Component/Validator/Mapping/Loader/YamlFileLoader.php

Line 70 in 6bdaf0b

return array_keys($this->classes);

In our case we got an error that array_keys expects an array which clearly can't be the case here.

This issue might as well be related to #20739
@lbayerl lbayerl changed the title New ValidationCacheWarmer incorrectly handles empty validation.yml [3.2][Validation] New ValidationCacheWarmer incorrectly handles empty validation.yml Dec 5, 2016
@nicolas-grekas nicolas-grekas mentioned this issue Dec 8, 2016
Merged
nicolas-grekas added a commit that referenced this issue Dec 8, 2016
@nicolas-grekas
bug #20828 [Validator] Fix init of YamlFileLoader::$classes for empty…
0aa80f2 
… files (nicolas-grekas)

This PR was merged into the 2.7 branch.

Discussion
----------

[Validator] Fix init of YamlFileLoader::$classes for empty files

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #20761
| License       | MIT
| Doc PR        | -

Commits
-------

073a1da [Validator] Fix init of YamlFileLoader::$classes for empty files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Status: Needs Review Validator
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@javiereguiluz @nicolas-grekas @lbayerl @carsonbot
0