8000 [Validator] Fix init of YamlFileLoader::$classes for empty files by nicolas-grekas · Pull Request #20828 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Validator] Fix init of YamlFileLoader::$classes for empty files #20828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 8, 2016
Merged

[Validator] Fix init of YamlFileLoader::$classes for empty files #20828

merged 1 commit into from
Dec 8, 2016

Conversation

nicolas-grekas
Copy link
Member
Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #20761
License MIT
Doc PR -

@stof
Copy link
Member
stof commented Dec 8, 2016

Would it be possible to write a test covering the actual bug (i.e. checking that getMappedClasses works) instead of asserting the internal property ? it would be more reliable (the class is free to do what it wants with its private property as long as the public API works fine)

@nicolas-grekas
Copy link
Member Author

The property is protected, so it's a "public" side effect, which means the test is good :)

@nicolas-grekas
Copy link
Member Author

@stof is this PR ok for you?

@nicolas-grekas
Copy link
Member Author

Note that this PR is against 2.7. getMappedClasses exists only on 3.2

@stof
Copy link
Member
stof commented Dec 8, 2016

👍
Status: reviewed

@nicolas-grekas nicolas-grekas merged commit 073a1da into symfony:2.7 Dec 8, 2016
nicolas-grekas added a commit that referenced this pull request Dec 8, 2016
@nicolas-grekas
bug #20828 [Validator] Fix init of YamlFileLoader::$classes for empty…
0aa80f2 
… files (nicolas-grekas)

This PR was merged into the 2.7 branch.

Discussion
----------

[Validator] Fix init of YamlFileLoader::$classes for empty files

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #20761
| License       | MIT
| Doc PR        | -

Commits
-------

073a1da [Validator] Fix init of YamlFileLoader::$classes for empty files
@nicolas-grekas nicolas-grekas deleted the fix-empty-valid branch December 8, 2016 15:58
This was referenced Dec 13, 2016
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Status: Reviewed Validator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolas-grekas @stof @carsonbot
0