-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
PR d83e346 breaks YAML parsing #19023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@userfriendly The link is broken, could you fix it? |
@paradajozsef Fixed. Sorry about that. |
I can confirm it, thx for reporting! Status: Reviewed. |
No, it's indeed breaking with that commit. |
@userfriendly Can you please check if #19028 fixes the issue for you? |
@xabbuh Yes, that does make lint:yaml very happy. 👍 |
@userfriendly Thanks for the confirmation. |
@xabbuh Thank you very much for fixing this! |
This PR was merged into the 2.7 branch. Discussion ---------- [Yaml] properly count skipped comment lines | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #15437, #17733, #19023 | License | MIT | Doc PR | Commits ------- da7fc36 [Yaml] properly count skipped comment lines
Uh oh!
There was an error while loading. Please reload this page.
lint:yaml complains about a YAML file not being valid under certain circumstances since commit d83e346 by @paradajozsef
Example file:
https://github.com/liuggio/ExcelBundle/blob/excel-forks/Resources/config/services.yml
In this case the error message mentions line 91. The issue appears to be related to a commented line following an array. When a blank line is inserted after line 89, before the comment in line 90, the error message is gone.
The text was updated successfully, but these errors were encountered: