10000 PR d83e346 breaks YAML parsing · Issue #19023 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

PR d83e346 breaks YAML parsing #19023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
userfriendly opened this issue Jun 10, 2016 · 9 comments
Closed

PR d83e346 breaks YAML parsing #19023

userfriendly opened this issue Jun 10, 2016 · 9 comments
Labels
Bug Status: Reviewed Yaml

Comments

@userfriendly
Copy link
Contributor
userfriendly commented Jun 10, 2016 •
edited
Loading

lint:yaml complains about a YAML file not being valid under certain circumstances since commit d83e346 by @paradajozsef

Example file:
https://github.com/liuggio/ExcelBundle/blob/excel-forks/Resources/config/services.yml

In this case the error message mentions line 91. The issue appears to be related to a commented line following an array. When a blank line is inserted after line 89, before the comment in line 90, the error message is gone.
@paradajozsef
Copy link
Contributor

@userfriendly The link is broken, could you fix it?

@userfriendly
Copy link
Contributor Author
userfriendly commented Jun 10, 2016 •
edited
Loading

@paradajozsef Fixed. Sorry about that.

@paradajozsef
Copy link
Contributor

I can confirm it, thx for reporting!

Status: Reviewed.

@xabbuh
Copy link
Member
xabbuh commented Jun 10, 2016 •
edited
Loading

If I am not mistaken, the even didn't work before. Can you confirm that?

No, it's indeed breaking with that commit.

xabbuh added a commit to xabbuh/symfony that referenced this issue Jun 10, 2016
@xabbuh
[WIP] fix symfony#19023
e198603
@xabbuh xabbuh mentioned this issue Jun 11, 2016
Merged
@xabbuh
Copy link
Member
xabbuh commented Jun 11, 2016

@userfriendly Can you please check if #19028 fixes the issue for you?

@userfriendly
Copy link
Contributor Author

@xabbuh Yes, that does make lint:yaml very happy. 👍

@xabbuh
Copy link
Member
xabbuh commented Jun 11, 2016

@userfriendly Thanks for the confirmation.

@paradajozsef
Copy link
Contributor

@xabbuh Thank you very much for fixing this!

@userfriendly
Copy link
Contributor Author
userfriendly commented Jun 11, 2016 •
edited
Loading

@awolder @DVelbeck please keep an eye on this while I'm in Germanland. Cheers!

fabpot added a commit that referenced this issue Jun 12, 2016
@fabpot
bug #19028 [Yaml] properly count skipped comment lines (xabbuh)
a77431c 
This PR was merged into the 2.7 branch.

Discussion
----------

[Yaml] properly count skipped comment lines

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #15437, #17733, #19023
| License       | MIT
| Doc PR        |

Commits
-------

da7fc36 [Yaml] properly count skipped comment lines
@fabpot fabpot closed this as completed Jun 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Status: Reviewed Yaml
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@fabpot @javiereguiluz @userfriendly @xabbuh @paradajozsef @carsonbot
0