8000
We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This yaml:
foo: - # bar bar: "123",
triggers: Unexpected characters near "," at line 3 (near "bar: "123",").
Unexpected characters near "," at line 3 (near "bar: "123",").
The line number is wrong (it should be 4). This is because Parser::getNextEmbedBlock() removes the comment line before the parse error occurs.
Parser::getNextEmbedBlock()
The text was updated successfully, but these errors were encountered:
Status: Reviewed
Sorry, something went wrong.
bug #17733 [Yaml] Fix wrong line number when comments are inserted in…
c04a999
… the middle of a block. (paradajozsef) This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #17733). Discussion ---------- [Yaml] Fix wrong line number when comments are inserted in the middle of a block. | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #15437 | License | MIT | Doc PR | - @xabbuh what is your opinion a solution like this? (counting the skipped comment lines and when exception occurs add them to the current line count.) Commits ------- d83e346 [Yaml] Fix wrong line number when comments are inserted in the middle of a block.
bug #19028 [Yaml] properly count skipped comment lines (xabbuh)
a77431c
This PR was merged into the 2.7 branch. Discussion ---------- [Yaml] properly count skipped comment lines | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #15437, #17733, #19023 | License | MIT | Doc PR | Commits ------- da7fc36 [Yaml] properly count skipped comment lines
No branches or pull requests