8000 [FWBundle] $_ENV fallback (needed for Panther) by dunglas · Pull Request #464 · symfony/recipes · GitHub
[go: up one dir, main page]
Skip to content

[FWBundle] $_ENV fallback (needed for Panther) #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statemen 8000 t. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Sep 21, 2018
Merged

[FWBundle] $_ENV fallback (needed for Panther) #464

1 commit merged into from
Sep 21, 2018

Conversation

dunglas
Copy link
Member
@dunglas dunglas commented Sep 20, 2018
Q A
License MIT

When the builtin PHP web server is used, env vars are only available in $_ENV, not in $_SERVER (see https://bugs.php.net/bug.php?id=67808).

This is especially annoying when testing an app with Panther because, by default, it automatically boots the app using the integrated PHP web server, consequently env vars defined in phpunit.xml aren't inherited, and the app executed using the dev env instead of the test one.

This PR fixes this problem.

ghost
ghost approved these changes Sep 20, 2018
View reviewed changes
Copy link
@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@dunglas dunglas mentioned this pull request Sep 20, 2018
Closed
bocharsky-bw
bocharsky-bw approved these changes Sep 21, 2018
View reviewed changes
Copy link
Contributor
@bocharsky-bw bocharsky-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes 👍

But we still need a way to be able to load websites in prod/test env when loading Symfony webserver in dev mode because, by default, the server is registered for dev mode only that makes sense, we should not register it for test/prod. See related #461 that may fix the issue I mentioned.

@bocharsky-bw bocharsky-bw mentioned this pull request Sep 21, 2018
Closed
sroze
sroze approved these changes Sep 21, 2018
View reviewed changes
Copy link
Contributor
@sroze sroze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point 👍

@ghost ghost merged commit 334f189 into symfony:master Sep 21, 2018
ghost pushed a commit that referenced this pull request Sep 21, 2018
Merge pull request #464
528f953
@dunglas dunglas mentioned this pull request Sep 23, 2018
Closed
@jrjohnson jrjohnson mentioned this pull request Sep 25, 2018
Closed
@albertboada
Copy link

Why not using getenv()?

@dunglas dunglas deleted the merge-env branch October 10, 2018 20:15
@dunglas
Copy link
Member Author
dunglas commented Oct 10, 2018

@albertboada because it's not thread safe.

@stof
Copy link
Member
stof commented Oct 11, 2018

Does DotEnv checks both $_SERVER and $_ENV for existing env variables too ?

@Pierstoval
Copy link
Contributor

@stof seems it's a handled case:

https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Dotenv/Dotenv.php#L81

@albertboada
Copy link
albertboada commented Oct 11, 2018 •
edited
Loading

@albertboada because it's not thread safe.

Thanks @dunglas, I see.

However, we are experimenting a situation where 'APP_ENV' is neither set in $_SERVER nor in $_ENV, and the only way of bootstrapping correctly our Symfony 4 application in our production is falling back to getenv(). We are deploying on Amazon Elastic Container Service. Any particular reason why this can happen?

EDIT:
Ok, found it. Sorry for the de-rail. For all those in the same situation, it is all about PHP's variables_order directive. Ours is set to variables_order = "GPCS", so the $_ENV array is not populated. From php.ini:

; This directive determines which super global arrays are registered when PHP
; starts up. G,P,C,E & S are abbreviations for the following respective super
; globals: GET, POST, COOKIE, ENV and SERVER. There is a performance penalty
; paid for the registration of these arrays and because ENV is not as commonly
; used as the others, ENV is not recommended on productions servers. You
; can still get access to the environment variables through getenv() should you
; need to.
; Default Value: "EGPCS"
; Development Value: "GPCS"
; Production Value: "GPCS";
; http://php.net/variables-order

One wonders, though. If the performance penalty is considerable, and it is not recommended in production environments, is it really sufficient to just check $_SERVER and $_ENV for bootstrapping Symfony?

Cheers!

@ThomasTr ThomasTr mentioned this pull request Apr 11, 2022
Open
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@sroze sroze sroze approved these changes

@bocharsky-bw bocharsky-bw bocharsky-bw approved these changes

@maxhelias maxhelias maxhelias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@dunglas @albertboada @stof @Pierstoval @nicolas-grekas @sroze @bocharsky-bw @maxhelias
0