Allow injecting env vars to web server process #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
requested changes
Jul 9, 2018
There was a problem hiding this comment.
It's already handled in Symfony Process: https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Process/Process.php#L1065-L1068
It's probably a config issue.
|
Investigating on the issue 😉 Then this PR becomes an RFC just to propose the end-user to add and/or overwrite env vars in the current web server! 😄 |
|
I've found the underlying issue, and I fixed the Flex recipe accordingly: symfony/recipes#464 Thank you very much for reporting this Alex! |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After I closed #18 I forgot to make another PR for this part.
I think it's essential to automatically inject env vars.
As we are using PHPUnit, env vars for the test execution should be set in
phpunit.xml.dist, therefore they'll be available in$_ENVthanks to PHPUnit, so we can safely inject them in the process.This will avoid it use the
.envfile when using the full-stack setup, and make sure we can isolate test env from dev env when using the same machine for both.