8000 Move translation dir to config/translations by ogizanagi · Pull Request #249 · symfony/recipes · GitHub
[go: up one dir, main page]
Skip to content

Move translation dir to config/translations #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Nov 11, 2017
Merged

Move translation dir to config/translations #249

1 commit merged into from
Nov 11, 2017

Conversation

@ogizanagi
Copy link
Contributor
@ogizanagi ogizanagi commented Nov 11, 2017
Q A
License MIT

To reflect default path choice made in symfony/symfony#24860.

ghost
ghost approved these changes Nov 11, 2017
View reviewed changes
Copy link
@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@ogizanagi ogizanagi mentioned this pull request Nov 11, 2017
Merged
2 tasks
@ogizanagi ogizanagi changed the title More translation dir to config/translations Move translation dir to config/translations Nov 11, 2017
ghost
ghost approved these changes Nov 11, 2017
View reviewed changes
Copy link
@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@ogizanagi ogizanagi force-pushed the update_trans_dir_location branch from dd7d752 to 4b5d97b Compare November 11, 2017 17:18
ghost
ghost approved these changes Nov 11, 2017
View reviewed changes
Copy link
@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@ghost ghost merged commit 4b5d97b into symfony:master Nov 11, 2017
ghost pushed a commit that referenced this pull request Nov 11, 2017
Merge pull request #249
db32040
@ogizanagi ogizanagi deleted the update_trans_dir_location branch November 11, 2017 17:52
@yceruto yceruto mentioned this pull request Nov 13, 2017
Closed
@javiereguiluz javiereguiluz mentioned this pull request Nov 13, 2017
Merged
@covex-nn covex-nn mentioned this pull request Feb 16, 2018
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ogizanagi @fabpot @nicolas-grekas
0