Update project to Symfony 4 beta4 #698
Conversation
| @@ -15,4 +15,5 @@ | |||
| Symfony\Bundle\WebServerBundle\WebServerBundle::class => ['dev' => true], | |||
| Symfony\Bundle\WebProfilerBundle\WebProfilerBundle::class => ['dev' => true, 'test' => true], | |||
| DAMA\DoctrineTestBundle\DAMADoctrineTestBundle::class => ['test' => true], | |||
| Doctrine\Bundle\MigrationsBundle\DoctrineMigrationsBundle::class => ['all' => true], | |||
There was a problem hiding this comment.
will it be worth add a bundle that we don't use? is there a way to avoid/skip the installation of a transitive package through composer?
There was a problem hiding this comment.
We don't use it (yet) but I think it's better to be 100% in sync with Symfony recipes.
|
What about to reflect the latest changes in symfony/symfony#24860 and symfony/recipes#249 in this PR? i.e. move |
src/Kernel.php
Outdated
| @@ -45,7 +45,9 @@ public function registerBundles() | |||
|
|
|||
| protected function configureContainer(ContainerBuilder $container, LoaderInterface $loader) | |||
| { | |||
| $confDir = dirname(__DIR__).'/config'; | |||
| $container->setParameter('container.autowiring.strict_mode', true); | |||
| $container->setParameter('container.dumper.inline_class_loader', true); | |||
There was a problem hiding this comment.
I think both behavior are enabled by default in 4.0 so they are not necessary.
There was a problem hiding this comment.
Hmmm, not container.dumper.inline_class_loader IIRC.
For container.autowiring.strict_mode, it just has no effect, as the BC layer for the old autowiring system is removed.
The |
|
Thanks for the reviews. I've fixed everything. I'd like to merge this as soon as possible to better prepare for the beta5 and/or final release. Thanks! |
Changelog:
Anybody knows what's going on with this unexpected output messages?