8000 Implement RFC 13 Passing CSS custom properties to components by tanhauhau · Pull Request #6237 · sveltejs/svelte · GitHub
[go: up one dir, main page]
Skip to content

Implement RFC 13 Passing CSS custom properties to components #6237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 30, 2021
Merged

Implement RFC 13 Passing CSS custom properties to components #6237

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e930d77
implement rfc 13
tanhauhau Apr 24, 2021
2268e8c
add test
tanhauhau Apr 24, 2021
70cc66a
tidy
Conduitry Apr 30, 2021
94128b7
hopefully fix tests on Windows
Conduitry Apr 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
hopefully fix tests on Windows
  • Loading branch information
@Conduitry
Conduitry committed Apr 30, 2021
commit 94128b707e029f41774c3ce1b47c588f06edaa46
10 changes: 5 additions & 5 deletions test/runtime-puppeteer/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,8 @@ describe('runtime (puppeteer)', () => {
load(id) {
if (id === 'main') {
return `
import SvelteComponent from '${__dirname}/samples/${dir}/main.svelte';
import config from '${__dirname}/samples/${dir}/_config.js';
import SvelteComponent from ${JSON.stringify(path.join(__dirname, 'samples', dir, 'main.svelte'))};
import config from ${JSON.stringify(path.join(__dirname, 'samples', dir, '_config.js'))};
import * as assert from 'assert';

export default async function (target) {
Expand Down Expand Up @@ -143,16 +143,16 @@ describe('runtime (puppeteer)', () => {
target,
window,
});

component.$destroy();

if (unhandled_rejection) {
throw unhandled_rejection;
}
} else {
component.$destroy();
assert.htmlEqual(target.innerHTML, '');

if (unhandled_rejection) {
throw unhandled_rejection;
}
Expand Down
0