8000 Implement RFC 13 Passing CSS custom properties to components by tanhauhau · Pull Request #6237 · sveltejs/svelte · GitHub
[go: up one dir, main page]
Skip to content

Implement RFC 13 Passing CSS custom properties to components #6237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 30, 2021
Merged

Implement RFC 13 Passing CSS custom properties to components #6237

merged 4 commits into from
Apr 30, 2021

Conversation

tanhauhau
Copy link
Member
@tanhauhau tanhauhau commented Apr 24, 2021 •
edited
Loading

Fixes #5628

Unable to test the runtime using JSDOM, because JSDOM does not apply css custom properties (ref: jsdom/jsdom#1895), so I added the runtime test case using puppeteer.

I created a runtime-puppeteer folder for runtime test case to be run with puppeteer. The test samples follow the format of the runtime tests, ie: configurable via the _config.js file

Before submitting the PR, please make sure you do the following

  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@tanhauhau tanhauhau force-pushed the tanhauhau/gh-5628-rfc-13 branch 2 times, most recently from 3e7cd8f to b7bd949 Compare April 24, 2021 06:28
@tanhauhau tanhauhau marked this pull request as ready for review April 24, 2021 06:28
@tanhauhau tanhauhau force-pushed the tanhauhau/gh-5628-rfc-13 branch from b7bd949 to 2268e8c Compare April 28, 2021 16:11
@Conduitry Conduitry merged commit 02b49a1 into sveltejs:master Apr 30, 2021
@tanhauhau tanhauhau deleted the tanhauhau/gh-5628-rfc-13 branch April 30, 2021 16:10
@benmccann benmccann mentioned this pull request Apr 30, 2021
Closed
@betaboon betaboon mentioned this pull request May 18, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement RFC 13
2 participants
@tanhauhau @Conduitry
0