Skip over dropped attributes when enumerating types #492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`pg_attribute` may contain records for attributes that were dropped but Postgres kept them around and instead of deleting them, renamed them to `........pg.dropped.#........` and set their `attisdropped` to `true`. This ends up generating these dropped attributes as `unknown` fields in the TypeScript types. In this commit I updated the `types` query to not return these. Maybe it would be preferrable to instead keep these but skip them only when generating the TypeScript types?
|
Interesting, thanks! Omitting dropped attributes sounds good to me. |
soedirgo
approved these changes
Jan 31, 2023
|
🎉 This PR is included in version 0.60.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
TomasHubelbauer
added a commit
to TomasHubelbauer/cli
that referenced
this pull request
Feb 2, 2023
Hi! This is a follow-up to this comment: supabase/postgres-meta#483 (comment) I am proposing an update of postgres-meta to version 0.60.6. I am hoping to make use of supabase/postgres-meta#492 through the Supabase CLI. As per the above linked comment, I am aware that in general, the postgres-meta version is kept at the same version as what is used on the hosted platform. This is a minor changes from the current version 0.60.3 so perhaps it will quality for an exception? I am not sure how I can check what version is live on the hosted platform. Thanks for considering!
avallete
pushed a commit
that referenced
this pull request
May 13, 2025
* Skip over dropped attributes when enumerating types `pg_attribute` may contain records for attributes that were dropped but Postgres kept them around and instead of deleting them, renamed them to `........pg.dropped.#........` and set their `attisdropped` to `true`. This ends up generating these dropped attributes as `unknown` fields in the TypeScript types. In this commit I updated the `types` query to not return these. Maybe it would be preferrable to instead keep these but skip them only when generating the TypeScript types? * use `not` --------- Co-authored-by: Bobbie Soedirgo <bobbie@soedirgo.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pg_attributemay contain records for attributes that were dropped but Postgres kept them around and instead of deleting them, renamed them to........pg.dropped.#........and set theirattisdroppedtotrue.This ends up generating these dropped attributes as
unknownfields in the TypeScript types.In this commit I updated the
typesquery to not return these.Maybe it would be preferrable to instead keep these but skip them only when generating the TypeScript types?
What kind of change does this PR introduce?
Feature? Maybe bug fix?
It is arguable whether these dropped attributes should appear in the generated types and be accessible via the Postgres Meta API. I expect folks might lean towards exposing them instead of skipping them. In this case I'd like to contribute a change which adds a new
droppedboolean field ontypesand then skips overdroppedtypes when generating composite types via the TypeScript generator.What is the current behavior?
Dropped attributes appear in generated TypeScript types.
It used to be that they would appear just as a line saying
unknown;.This seems to have been fixed on
master, not they actually display the renamed name:See #483 for the PR that fixed this.
Yet these are not useful in the types since they are dropped and I happen to think they shouldn't be in the TypeScript types. It is arguable whether they should be in
pgMeta.types.list. I can see an argument for both cases.What is the new behavior?
pgMeta.types.listskips overattisdropped=trueattributes.As a result, the TypeScript types skip over them as well when generating composite types (among other types?).
I am happy to change the PR to instead skip over these at the TypeScript generator level so they remain accessible in
pgMeta.types.list.