8000 fix: return field name with composite type unknown by kartikk-k · Pull Request #483 · supabase/postgres-meta · GitHub
[go: up one dir, main page]

Skip to content

fix: return 8000 field name with composite type unknown #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 27, 2023

Conversation

kartikk-k
Copy link
Contributor

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

Current behavior - issue #478

What is the new behavior?

line 310
return `${JSON.stringify(name)}: unknown`

@kartikk-k kartikk-k requested a review from a team as a code owner January 24, 2023 12:56
@sweatybridge sweatybridge changed the title fixed return unknown to name typed unknown - issue #478 fix: return field name with composite type unknown Jan 27, 2023
@sweatybridge sweatybridge merged commit e4251fa into supabase:master Jan 27, 2023
@github-actions
Copy link

🎉 This PR is included in version 0.60.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@TomasHubelbauer
Copy link
Contributor

@sweatybridge This fix doesn't seem to appear in the Supabase CLI version 1.35.0 which was cut yesterday and this PR 8000 was merged three days ago. I was under the impression that the Supabase CLI would take the latest version of postgres-meta for its release every time. Is this incorrect? And how can I determine when this fix will be available in the CLI? Thank you 🙏

@sweatybridge
Copy link
Contributor

@TomasHubelbauer thanks for following up with these questions. I've bumped pgmeta in CLI 1.35.2 and try to answer some of these below.

I was under the impression that the Supabase CLI would take the latest version of postgres-meta for its release every time. Is this incorrect?

Generally for consistency, the CLI uses the same version of pgmeta that's deployed on hosted platform. If there's an urgent or minor fix needed for CLI, we can update early on a per request basis.

And how can I determine when this fix will be available in the CLI?

Our release schedule is quite flexible as we are a small team of maintainers. Since the CLI is also an OSS project, we would encourage anyone to contribute a PR for updating the code or dependency versions. By making a PR, you can track the release status of your fix when it is merged.

@kartikk-k
Copy link
Contributor Author

@TomasHubelbauer thanks for following up with these questions. I've bumped pgmeta in CLI 1.35.2 and try to answer some of these below.

I was under the impression that the Supabase CLI would take the latest version of postgres-meta for its release every time. Is this incorrect?

Generally for consistency, the CLI uses the same version of pgmeta that's deployed on hosted platform. If there's an urgent or minor fix needed for CLI, we can update early on a per request basis.

And how can I determine when this fix will be available in the CLI?

Our release schedule is quite flexible as we are a small team of maintainers. Since the CLI is also an OSS project, we would encourage anyone to contribute a PR for updating the code or dependency versions. By making a PR, you can track the release status of your fix when it is merged.

Can you guide me little bit about updating dependency versions or provide any any reference so that I can make PR and fix this issue?

@sweatybridge
Copy link
Contributor

Yup, it's as straightforward as updating the image version used by cli. Here's an examp 8000 le https://github.com/supabase/cli/pull/824/files.

You can find the latest image tag published on docker hub.

TomasHubelbauer added a commit to TomasHubelbauer/cli that referenced this pull request Feb 2, 2023
Hi! This is a follow-up to this comment:
supabase/postgres-meta#483 (comment)

I am proposing an update of postgres-meta to version 0.60.6.
I am hoping to make use of supabase/postgres-meta#492 through the Supabase CLI.

As per the above linked comment, I am aware that in general, the postgres-meta version is kept at the same version as what is used on the hosted platform.
This is a minor changes from the current version 0.60.3 so perhaps it will quality for an exception?
I am not sure how I can check what version is live on the hosted platform.

Thanks for considering!
avallete pushed a commit that referenced this pull request May 13, 2025
* fixed return unknown to name typed unknown

* chore: fix formatting

Co-authored-by: Qiao Han <qiao@supabase.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0