-
-
Notifications
You must be signed in to change notification settings - Fork 141
fix: return 8000 field name with composite type unknown #483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎉 This PR is included in version 0.60.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@sweatybridge This fix doesn't seem to appear in the Supabase CLI version 1.35.0 which was cut yesterday and this PR 8000 was merged three days ago. I was under the impression that the Supabase CLI would take the latest version of postgres-meta for its release every time. Is this incorrect? And how can I determine when this fix will be available in the CLI? Thank you 🙏 |
@TomasHubelbauer thanks for following up with these questions. I've bumped pgmeta in CLI 1.35.2 and try to answer some of these below.
Generally for consistency, the CLI uses the same version of pgmeta that's deployed on hosted platform. If there's an urgent or minor fix needed for CLI, we can update early on a per request basis.
Our release schedule is quite flexible as we are a small team of maintainers. Since the CLI is also an OSS project, we would encourage anyone to contribute a PR for updating the code or dependency versions. By making a PR, you can track the release status of your fix when it is merged. |
Can you guide me little bit about updating dependency versions or provide any any reference so that I can make PR and fix this issue? |
Yup, it's as straightforward as updating the image version used by cli. Here's an examp 8000 le https://github.com/supabase/cli/pull/824/files. You can find the latest image tag published on docker hub. |
Hi! This is a follow-up to this comment: supabase/postgres-meta#483 (comment) I am proposing an update of postgres-meta to version 0.60.6. I am hoping to make use of supabase/postgres-meta#492 through the Supabase CLI. As per the above linked comment, I am aware that in general, the postgres-meta version is kept at the same version as what is used on the hosted platform. This is a minor changes from the current version 0.60.3 so perhaps it will quality for an exception? I am not sure how I can check what version is live on the hosted platform. Thanks for considering!
* fixed return unknown to name typed unknown * chore: fix formatting Co-authored-by: Qiao Han <qiao@supabase.io>
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Current behavior - issue #478
What is the new behavior?
line 310
return `${JSON.stringify(name)}: unknown`