Add migration with admin option for permissions to administer roles for postgres role beyond pg16
#1625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ister roles beyond pg16
|
@encima migration LGTM but obviously need a repo approver. However - to confirm I'm seeing on the NIx CI / build psql. Is this a normal build failure?
|
pashkinelfe
reviewed
Jun 5, 2025
pcnc
approved these changes
Jun 5, 2025
srcCraftsman
approved these changes
Jun 5, 2025
za-arthur
reviewed
Jun 5, 2025
There was a problem hiding this comment.
Tests need to be adapted:
postgres/nix/tests/expected/roles.out
Lines 120 to 126 in 4039e4c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fix
What is the current behavior?
PG17 and above does not apply the
with adminoption for the postgres roleWhat is the new behavior?
Apply role permissions for postgres role on versions beyond PG16
Additional context
Changelog