8000 Add migration `with admin` option for permissions to administer roles for postgres role beyond pg16 by encima · Pull Request #1625 · supabase/postgres · GitHub
[go: up one dir, main page]
Skip to content

Add migration with admin option for permissions to administer roles for postgres role beyond pg16 #1625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 5, 2025
Merged

Add migration with admin option for permissions to administer roles for postgres role beyond pg16 #1625

merged 9 commits into from
Jun 5, 2025

Conversation

encima
Copy link
Member
@encima encima commented Jun 5, 2025

What kind of change does this PR introduce?

Fix

What is the current behavior?

PG17 and above does not apply the with admin option for the postgres role

What is the new behavior?

Apply role permissions for postgres role on versions beyond PG16

Additional context

Changelog

@encima encima requested review from a team as code owners June 5, 2025 14:29
@carusocv
Copy link
carusocv commented Jun 5, 2025

@encima migration LGTM but obviously need a repo approver.

However - to confirm I'm seeing on the NIx CI / build psql. Is this a normal build failure?

This step has been truncated due to its large size. Download the full logs from the menu once the workflow run has completed.

pashkinelfe
pashkinelfe reviewed Jun 5, 2025
View reviewed changes
Copy link
Contributor
@pashkinelfe pashkinelfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could ALTER ROLE postgres CREATEROLE needed?

za-arthur
za-arthur reviewed Jun 5, 2025
View reviewed changes
Copy link
Contributor
@za-arthur za-arthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests need to be adapted:

postgres/nix/tests/expected/roles.out

Lines 120 to 126 in 4039e4c

postgres | anon | f
postgres | authenticated | f
postgres | pg_monitor | f
postgres | pg_read_all_data | f
postgres | pg_signal_backend | f
postgres | pgtle_admin | f
postgres | service_role | f

@pcnc pcnc merged commit 9669e7b into develop Jun 5, 2025
8 of 14 checks passed
@pcnc pcnc deleted the hotfix/pg17-alter-with-admin branch June 5, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@za-arthur za-arthur za-arthur left review comments

@pashkinelfe pashkinelfe pashkinelfe left review comments

@pcnc pcnc pcnc approved these changes

@srcCraftsman srcCraftsman srcCraftsman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@encima @carusocv @za-arthur @pcnc @srcCraftsman @pashkinelfe @soedirgo
0