-
-
Notifications
You must be signed in to change notification settings - Fork 615
Update devdeps figure hashes #5399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think there will need to be a bisection to look for some change in Matplotlib. PR #5395's run of devdeps from two days ago does not show any non-colorbar differences in the figure tests: |
I'd be tempted to say the differences are all so small as to be not a problem. Looking at the commit log (https://github.com/matplotlib/matplotlib/commits/master), it might be matplotlib/matplotlib#20363, but MPL didn't change any of their test images in that PR, so it might be an interaction with that and |
It looks like they relaxed a tolerance for an image check. Yes, we could simply update our hashes, but that Matplotlib PR may also be responsible for this contour craziness in #5398: |
Zooming into one of the figure tests that changed, the lines are still in the same place. So I think this is probably some sort of change in the aliasing of paths, and it's safe to change the hashes and merge once #5398 is merged. |
cc6fb22
to
92e7a18
Compare
This should be good to go now - I've confirmed that all the changes are just in the way lines are drawn, and not in their location. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub.
git fetch
# Create new working tree.
git worktree add .worktrees/backport 3.0
# Navigate to the new directory.
cd .worktrees/backport
# Cherry-pick all the commits of this pull request and resolve the likely conflicts.
git cherry-pick 6fd711369afbe0ebd2ee0c67e048be0df3275d06
# Create a new branch with these backported commits.
git checkout -b backport-5399-to-3.0
# Push it to GitHub.
git push --set-upstream origin backport-5399-to-3.0
# Go back to the original working tree.
cd ../..
# Delete the working tree.
git worktree remove .worktrees/backport Then, create a pull request where the |
I think some of the devdeps figure hashes need updating for recent coordinate fixes, so here's an empty commit to see if the tests pass or the hashes do indeed need updating.