Don't disable path clipping on paths with codes. #20363
Conversation
|
Seems good. Do you know if there's any other uses of has_curves() that should likewise be fixed? |
|
It's also passed to |
|
The change is in the last Axes: These three paths are from contour, and have |
|
would e.g. setting |
|
Unfortunately not, tuning it down to 0 still fails at about 0.588 RMS, and thresholds in between are still a bit off. |
|
I guess I could live with putting that tol here. |
When `PathClipper` is applied, it is disabled if `has_curves()` is true. However, that method simply checks if the Path has _codes_, not curves. This means Paths created with codes, but using only MOVETO/LINETO, are not clipped when they could be. Additionally, the description for `PathClipper` says that "Curve segments are not clipped, but are always included in their entirety.", meaning there is no need to turn it off when the Path contains curves, as they will at least be handled, if not fully clipped.
1918143 to
81aa223
Compare
|
Done, actually default simplify threshold is even lower RMS. |
PR Summary
When
PathClipperis applied, it is disabled ifhas_curves()is true. However, that method simply checks if the Path has codes, not curves. This means Paths created with codes, but using only MOVETO/LINETO, are not clipped when they could be.Additionally, the description for
PathClippersays that "Curve segments are not clipped, but are always included in their entirety.", meaning there is no need to turn it off when the Path contains curves, as they will at least be handled, if not fully clipped.PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).