Increasing Coverage Message Processor : From 79% to 94% #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awsarron
requested changes
May 26, 2025
There was a problem hiding this comment.
Thanks @fede-dash, this is great! A couple of small comments and then we'll merge this.
|
Ready for Review |
awsarron
requested changes
May 27, 2025
There was a problem hiding this comment.
Thanks @fede-dash.
Small one: when running hatch fmt I get some reformatting:
cmd [1] | ruff check --fix
All checks passed!
cmd [2] | ruff format
1 file reformatted, 100 files left unchanged
Will merge after this.
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🧪 Test Suite Overview for message_processor
This test module provides coverage for key utility functions in message_processor.py under strands.event_loop, specifically validating behavior related to message sanitization and correction in tool use scenarios. The tests are structured with pytest and include parameterized inputs for robustness.
✅ test_clean_orphaned_empty_tool_uses
Tests the function clean_orphaned_empty_tool_uses, which removes or replaces toolUse messages that:
• Have empty input
• Do not have a matching toolResult
This ensures the message history doesn’t contain stale or incomplete tool use entries. The test checks both whether the cleanup happened and what the cleaned messages look like.
🔍 test_find_last_message_with_tool_results
Validates find_last_message_with_tool_results, which scans a message list to find the last occurrence of a toolResult. This is useful for indexing or pruning based on tool result placement.
✂️ test_truncate_tool_results
Covers truncate_tool_results, which modifies a specific message to mark its toolResult as errored (e.g., when the result is too large). The function updates the content and returns a flag indicating whether the modification occurred.
Each test ensures:
• Correct handling of edge cases (empty inputs, invalid indexes)
• No side effects on input data (using deepcopy)
• Expected message transformations or detection logic
Type of Change
Before
After
[Choose one of the above types of changes]
Testing
[How have you tested the change?]
hatch fmt --linterhatch fmt --formatterhatch test --allChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.