8000 Increasing Coverage Message Processor : From 79% to 94% by fede-dash · Pull Request #115 · strands-agents/sdk-python · GitHub
[go: up one dir, main page]
Skip to content

Increasing Coverage Message Processor : From 79% to 94% #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025
Merged

Increasing Coverage Message Processor : From 79% to 94% #115

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
< 8000 h5 data-view-component="true" class="mb-2"> Diff view
Diff view
128 changes: 128 additions & 0 deletions tests/strands/event_loop/test_message_processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,128 @@
import copy

import pytest

from strands.event_loop import message_processor


@pytest.mark.parametrize(
"messages,expected,expected_messages",
[
# Orphaned toolUse with empty input, no toolResult
(
[
{"role": "assistant", "content": [{"toolUse": {"toolUseId": "1", "input": {}, "name": "foo"}}]},
{"role": "user", "content": [{"toolResult": {"toolUseId": "2"}}]},
],
True,
[
{"role": "assistant", "content": [{"text": "[Attempted to use foo, but operation was canceled]"}]},
{"role": "user", "content": [{"toolResult": {"toolUseId": "2"}}]},
],
),
# toolUse with input, has matching toolResult
(
[
{"role": "assistant", "content": [{"toolUse": {"toolUseId": "1", "input": {"a": 1}, "name": "foo"}}]},
{"role": "user", "content": [{"toolResult": {"toolUseId": "1"}}]},
],
False,
[
{"role": "assistant", "content": [{"toolUse": {"toolUseId": "1", "input": {"a": 1}, "name": "foo"}}]},
{"role": "user", "content": [{"toolResult": {"toolUseId": "1"}}]},
],
),
# No messages
(
[],
False,
[],
),
],
)
def test_clean_orphaned_empty_tool_uses(messages, expected, expected_messages):
test_messages = copy.deepcopy(messages)
result = message_processor.clean_orphaned_empty_tool_uses(test_messages)
assert result == expected
assert test_messages == expected_messages


@pytest.mark.parametrize(
"messages,expected_idx",
[
(
[
{"role": "user", "content": [{"text": "hi"}]},
{"role": "user", "content": [{"toolResult": {"toolUseId": "1"}}]},
{"role": "assistant", "content": [{"text": "ok"}]},
],
1,
),
(
[
{"role": "user", "content": [{"text": "hi"}]},
{"role": "assistant", "content": [{"text": "ok"}]},
],
None,
),
(
[],
None,
),
],
)
def test_find_last_message_with_tool_results(messages, expected_idx):
idx = message_processor.find_last_message_with_tool_results(messages)
assert idx == expected_idx


@pytest.mark.parametrize(
"messages,msg_idx,expected_changed,expected_content",
[
(
[
{
"role": "user",
"content": [{"toolResult": {"toolUseId": "1", "status": "ok", "content": [{"text": "big"}]}}],
}
],
0,
True,
[
{
"toolResult": {
"toolUseId": "1",
"status": "error",
"content": [{"text": "The tool result was too large!"}],
}
}
],
),
(
[{"role": "user", "content": [{"text": "no tool result"}]}],
0,
False,
[{"text": "no tool result"}],
),
(
[],
0,
False,
[],
),
(
[{"role": "user", "content": [{"toolResult": {"toolUseId": "1"}}]}],
2,
False,
[{"toolResult": {"toolUseId": "1"}}],
),
],
)
def test_truncate_tool_results(messages, msg_idx, expected_changed, expected_content):
test_messages = copy.deepcopy(messages)
changed = message_processor.truncate_tool_results(test_messages, msg_idx)
assert changed == expected_changed
if 0 <= msg_idx < len(test_messages):
assert test_messages[msg_idx]["content"] == expected_content
else:
assert test_messages == messages
0