E5E0 ROX-31146: Reduce spam of Konflux PRs, releasers can approve by msugakov · Pull Request #17968 · stackrox/stackrox · GitHub
[go: up one dir, main page]
Skip to content

ROX-31146: Reduce spam of Konflux PRs, releasers can approve #17968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msugakov merged 4 commits into from
Dec 3, 2025
Merged

ROX-31146: Reduce spam of Konflux PRs, releasers can approve #17968

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6fbef80
Update codeowners
msugakov Nov 26, 2025
74dedf8
Add workflow for tagging konflux-maintainers for review
msugakov Nov 26, 2025
2fdfa9b
Get rid of `exec`, switch to `gh pr edit`
msugakov Dec 2, 2025
2d5bcee
Updated CODEOWNERS comment
msugakov Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,12 +81,14 @@ operator/**/* @stackrox/install
/sensor/kubernetes/listener/resources/secrets* @stackrox/scanner
/SCANNER_VERSION @stackrox/scanner

# The RHTAP maintainers for ACS review all changes related to the Konflux (f.k.a. RHTAP) pipelines, such as new
# pipelines, parameter changes or automated task updates as well as Dockerfile updates.
**/konflux.*Dockerfile @stackrox/rhtap-maintainers
/.konflux/ @stackrox/rhtap-maintainers
/.tekton/ @stackrox/rhtap-maintainers
rpms.* @stackrox/rhtap-maintainers
# Konflux maintainers for ACS review all changes related to the Konflux pipelines, Dockerfiles, etc.
# Release engineers need to merge MintMaker PRs at the time of the release.
# rhacs-bot needs an ability to auto-approve MintMaker PRs for automated task and security updates.
**/konflux.*Dockerfile @stackrox/konflux-maintainers-no-email @stackrox/release-mgmt-no-email @rhacs-bot
/.tekton/ @stackrox/konflux-maintainers-no-email @stackrox/release-mgmt-no-email @rhacs-bot
rpms.* @stackrox/konflux-maintainers-no-email @stackrox/release-mgmt-no-email @rhacs-bot
/.konflux/ @stackrox/konflux-maintainers
.github/renovate.json5 @stackrox/konflux-maintainers


# Dependencies
Expand Down
26 changes: 26 additions & 0 deletions .github/workflows/tag-more-reviewers.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
name: Tag more reviewers

on:
pull_request:
types:
- review_requested

jobs:
tag-konflux-maintainers:
# We have lots of PR traffic from MintMaker (acting as `red-hat-konflux[bot]`), and so it's unsustainable to go
# through these emails every day. Therefore, the notifications are disabled for `konflux-maintainers-no-email`
# team that's set as owner in CODEOWNERS for the Konflux stuff.
# At the same time, we want to be notified when humans, not the bot, request reviews (which happens automatically
# again through CODEOWNERS) for the Konflux-related files. This job invites `konflux-maintainers` team for review
# for such cases.
if: |
github.event.requested_team.name == 'konflux-maintainers-no-email' &&
github.event.pull_request.user.login != 'red-hat-konflux[bot]'
env:
GH_TOKEN: ${{ secrets.RHACS_BOT_GITHUB_TOKEN }}
runs-on: ubuntu-latest
steps:
- name: Tag Konflux Maintainers for review
run: |
gh pr --repo "${{ github.repository }}" edit "${{ github.event.pull_request.number }}" \
--add-reviewer stackrox/konflux-maintainers
Loading
0