ROX-31146: Reduce spam of Konflux PRs, releasers can approve#17968
Merged
ROX-31146: Reduce spam of Konflux PRs, releasers can approve#17968
Conversation
Contributor
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Since this workflow relies on
RHACS_BOT_GITHUB_TOKEN, consider adding a guard likeif: github.event.pull_request.head.repo.full_name == github.repositoryat the job level to avoid unnecessary failures on PRs from forks where the secret is unavailable. - To make the intent clearer and avoid accidental triggering in other review-request scenarios, you could explicitly check the action type in the job condition (e.g.
if: github.event.action == 'review_requested' && github.event.requested_team.name == 'konflux-maintainers-no-email' && github.event.pull_request.user.login != 'red-hat-konflux[bot]').
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since this workflow relies on `RHACS_BOT_GITHUB_TOKEN`, consider adding a guard like `if: github.event.pull_request.head.repo.full_name == github.repository` at the job level to avoid unnecessary failures on PRs from forks where the secret is unavailable.
- To make the intent clearer and avoid accidental triggering in other review-request scenarios, you could explicitly check the action type in the job condition (e.g. `if: github.event.action == 'review_requested' && github.event.requested_team.name == 'konflux-maintainers-no-email' && github.event.pull_request.user.login != 'red-hat-konflux[bot]'`).Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
tommartensen
approved these changes
Nov 26, 2025
Contributor
|
Images are ready for the commit at 2d5bcee. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #17968 +/- ##
==========================================
- Coverage 49.48% 49.45% -0.04%
==========================================
Files 2697 2699 +2
Lines 198048 198270 +222
==========================================
+ Hits 98010 98060 +50
- Misses 92402 92605 +203
+ Partials 7636 7605 -31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
janisz
reviewed
Nov 26, 2025
janisz
reviewed
Nov 26, 2025
janisz
reviewed
Nov 26, 2025
1 task
Contributor
Author
|
Tested https://github.com/stackrox/mishas-operator-index-fork/actions/runs/19868379156/job/56937179337?pr=1 
https://github.com/stackrox/mishas-operator-index-fork/pull/1 Note: both links will stop working as I plan to delete that test repo. |
janisz
approved these changes
Dec 3, 2025
msugakov
added a commit
to stackrox/collector
that referenced
this pull request
Dec 3, 2025
msugakov
added a commit
that referenced
this pull request
Dec 3, 2025
msugakov
added a commit
that referenced
this pull request
Dec 3, 2025
msugakov
added a commit
that referenced
this pull request
Dec 3, 2025
ajheflin
pushed a commit
that referenced
this pull request
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Same as stackrox/scanner#2438 and stackrox/collector#2693 but applied to StackRox.
We don't have
auto-approveworkflow here but we still need@rhacs-botto be the codeowner. Otherwise no-notification magic won't work. Perhaps we'll add auto-approve in the future.User-facing documentation
Testing and quality
Automated testing
No change.
How I validated my change
Tested on the Scanner repo before. Also tested the updated command on a fork.