Remove pkg_resources
#294
Open
Remove pkg_resources
#294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes `pkg_resources` requirements as they are deprecated with more recent versions of Python. - `importlib.metadata.distribution` is used in place of `pkg_resources.get_distribution` - `importlib.metadata.version` is used in place of `pkg_resources.version` - `ModuleNotFoundError` is used instead of `pkg_resources.DistributionNotFound`
mlucool
reviewed
Dec 8, 2023
This commit removes all references to `pkg_resources`. - Bumped version numbers for found in `requirements-docs` in order to build the documentation using `tox`. - Removed all references to `pkg_resources` in `sqlalchemy_redshift/__init__.py` and `sqlalchemy_redshift/dialect.py`. - Updated the `tests/test_default_ssl.py` to no longer use `pkg_resources`.
|
@Brooke-white is there someone I should ping to look at this PR, or is this also meant to be a part of the work being done in #264? Thanks again for the tool, yours and everyone else's work with it has been greatly appreciated. |
|
Hey all, I'm interested in getting this merged. Is there anything I can do to help get this across the line? |
|
Bump |
4 tasks
perrito666
added a commit
to Shiphero/sqlalchemy-redshift
that referenced
this pull request
Apr 15, 2025
… with more recent versions of Python. importlib.metadata.distribution is used in place of pkg_resources.get_distribution importlib.metadata.version is used in place of pkg_resources.version ModuleNotFoundError is used instead of pkg_resources.DistributionNotFound Port of sqlalchemy-redshift#294
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes
pkg_resourcesrequirements as they are deprecated with more recent versions of Python.importlib.metadata.distributionis used in place ofpkg_resources.get_distributionimportlib.metadata.versionis used in place ofpkg_resources.versionModuleNotFoundErroris used instead ofpkg_resources.DistributionNotFoundTodos