Issue291/pkg resources #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes `pkg_resources` requirements as they are deprecated with more recent versions of Python. - `importlib.metadata.distribution` is used in place of `pkg_resources.get_distribution` - `importlib.metadata.version` is used in place of `pkg_resources.version` - `ModuleNotFoundError` is used instead of `pkg_resources.DistributionNotFound`
This commit removes all references to `pkg_resources`. - Bumped version numbers for found in `requirements-docs` in order to build the documentation using `tox`. - Removed all references to `pkg_resources` in `sqlalchemy_redshift/__init__.py` and `sqlalchemy_redshift/dialect.py`. - Updated the `tests/test_default_ssl.py` to no longer use `pkg_resources`.
… with more recent versions of Python. importlib.metadata.distribution is used in place of pkg_resources.get_distribution importlib.metadata.version is used in place of pkg_resources.version ModuleNotFoundError is used instead of pkg_resources.DistributionNotFound Port of sqlalchemy-redshift#294
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes pkg_resources requirements as they are deprecated with more recent versions of Python.
importlib.metadata.distribution is used in place of pkg_resources.get_distribution importlib.metadata.version is used in place of pkg_resources.version ModuleNotFoundError is used instead of pkg_resources.DistributionNotFound
Port of sqlalchemy-redshift#294