8000 Simplify InternalsVisibleTo by kzu · Pull Request #1634 · spectreconsole/spectre.console · GitHub
[go: up one dir, main page]

Skip to content

Simplify InternalsVisibleTo#1634

Merged
patriksvensson merged 1 commit intospectreconsole:mainfrom
kzu:ivt
Sep 6, 2024
Merged

Simplify InternalsVisibleTo#1634
patriksvensson merged 1 commit intospectreconsole:mainfrom
kzu:ivt

Conversation

@kzu
Copy link
Contributor
@kzu kzu commented Sep 5, 2024

If the $(PublicKey) property is used, the SDK targets will automatically use it for the assembly attributes.

See dotnet/sdk#3439

Simplifies #1623


Please upvote 👍 this pull request if you are interested in it.

If the $(PublicKey) property is used, the SDK targets will automatically use it for the assembly attributes.

See dotnet/sdk#3439

Simplifies spectreconsole#1623
@kzu
Copy link
Contributor Author
kzu commented Sep 5, 2024

FYI @KirillOsenkov, I made it so $(PublicKey) is automatically picked up by <InternalsVisibleTo ...> 😉

@github-actions github-actions bot added the ⭐ top pull request Top pull request. label Sep 6, 2024
@KirillOsenkov
Copy link
Contributor

Nice! I didn't know this exists. And you've added it to the SDK in the first place!

Copy link
Contributor
@patriksvensson patriksvensson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@patriksvensson patriksvensson merged commit 8e44a83 into spectreconsole:main Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⭐ top pull request Top pull request.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0