Strong name the assemblies#1623
Conversation
|
Huge thanks to @sebastienros for the original PR. |
|
Yours is better, you know how to use msbuild ;) |
|
Companion PR: spectresystems/spectre.verify.extensions#10 Once that merges and we update Spectre.Verify.Extensions in this repo, we can remove the NoWarn here: I was also wondering why there's a separate Directory.Build.props in the Tests directory. All the three properties that it sets are already set by the parent. However the parent Directory.Build.props will not be automatically imported. If you want it to be imported you need to add: |
|
Merged! Thank you for your contribution. Much appreciated! 👍 |
If the $(PublicKey) property is used, the SDK targets will automatically use it for the assembly attributes. See dotnet/sdk#3439 Simplifies spectreconsole#1623
If the $(PublicKey) property is used, the SDK targets will automatically use it for the assembly attributes. See dotnet/sdk#3439 Simplifies #1623
Revival of #687
fixes #481
Changes
Adds a strong name key pair and signs all assemblies using the .snk file. Temporarily suppresses one warning until Spectre.Verify.Extensions is signed (in a separate PR).
Please upvote 👍 this pull request if you are interested in it.