fix: cadvisor can pickup oom events #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7dbaeed to
7a9386c
Compare
Member
Author
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
7a9386c to
ca565f2
Compare
michaellzc
commented
May 5, 2022
Comment on lines
+85
to
+89
| {{- if .Values.cadvisor.containerSecurityContext.privileged }} | ||
| - name: kmsg | ||
| mountPath: /dev/kmsg | ||
| readOnly: true | ||
| {{- end }} |
Member
Author
There was a problem hiding this comment.
maybe I am overcomplicating things.
without privileged and we mount the /dev/kmsg, users would see the below logs from cadvisor.
k logs daemonset/cadvisor 14:05:31
Found 2 pods, using pod/cadvisor-qkdlk
W0505 21:05:23.014872 1 machine_libipmctl.go:63] There are no NVM devices!
W0505 21:05:23.068489 1 manager.go:296] Could not configure a source for OOM detection, disabling OOM events: open /dev/kmsg: operation not permitted
If we don't mount /dev/kmsg, users will always see something like
Could not configure a source for OOM detection, disabling OOM events: open /dev/kmsg: no such file or directory
either one of them is not ideal, so I figure we should just don't mount unnecessary stuff when it has no used (privielged=false)
michaellzc
commented
May 5, 2022
Comment on lines
+127
to
+131
| {{- if .Values.cadvisor.containerSecurityContext.privileged }} | ||
| - name: kmsg | ||
| hostPath: | ||
| path: /dev/kmsg | ||
| {{- end }} |
Member
Author
There was a problem hiding this comment.
there's no docker's --device equivalent in Kubernetes, so we have to mount it as a regular volume.
aa07085 to
80903f6
Compare
80903f6 to
7773c31
Compare
4 tasks
caugustus-sourcegraph
approved these changes
May 6, 2022
Co-authored-by: Crystal Augustus <91073224+caugustus-sourcegraph@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up sourcegraph/deploy-sourcegraph-docker#804
Checklist
Test plan
tested on a live gke cluster
deploy sourcegraph as usual
deploy a stress test pod
apiVersion: v1 kind: Pod metadata: name: stress namespace: sourcegraph spec: containers: - name: stress image: progrium/stress command: - sleep - infinity resources: requests: memory: 100Mi limits: memory: 128Miexec into the pod and run
oom events show up as expected