8000 fix: cadvisor can pickup oom events by michaellzc · Pull Request #4126 · sourcegraph/deploy-sourcegraph · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Jun 9, 2025. It is now read-only.

fix: cadvisor can pickup oom events #4126

Merged
michaellzc merged 1 commit into from
May 6, 2022
Merged

fix: cadvisor can pickup oom events #4126

michaellzc merged 1 commit into from
May 6, 2022

Conversation

@michaellzc
Copy link
Member
@michaellzc michaellzc commented May 6, 2022 •
edited
Loading

Follow up sourcegraph/deploy-sourcegraph-docker#804
Related: https://github.com/sourcegraph/sourcegraph/pull/35030

Checklist

Test plan

OOM events

Tested on a GKE cluster

cadvisor did not complain about no kmsg device or operation not permitted

$ k logs -l app=cadvisor                                                                                                                                                                                                                                                                  18:15:22
W0506 01:14:46.029975       1 machine_libipmctl.go:63] There are no NVM devices!
W0506 01:14:46.274086       1 machine_libipmctl.go:63] There are no NVM devices!

Then follow the exact same test plan in sourcegraph/deploy-sourcegraph-helm#121

Non-privileged overlay

./overlay-generate-cluster.sh non-privileged generated-cluster

inspect generated-cluster/apps_v1_daemonset_cadvisor.yaml

no present of privielged and /dev/kmsg in volumes & volumeMounts

@michaellzc michaellzc force-pushed the 05-05-fix_cadvisor_can_pickup_oom_events branch from 74d46a4 to ac5c4b8 Compare May 6, 2022 00:31
@michaellzc michaellzc mentioned this pull request May 6, 2022
Merged
@michaellzc michaellzc requested a review from a team May 6, 2022 01:28
@michaellzc michaellzc merged commit 9e2eed7 into master May 6, 2022
@michaellzc michaellzc deleted the 05-05-fix_cadvisor_can_pickup_oom_events branch May 6, 2022 19:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@caugustus-sourcegraph caugustus-sourcegraph caugustus-sourcegraph approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@michaellzc @caugustus-sourcegraph
0