Update postgresql conf #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
michaellzc
commented
Apr 9, 2022
| {{ tpl .Values.codeInsightsDB.additionalConfig . | nindent 4 | trim }} | ||
| {{- .Files.Get "files/codeinsights-db/conf/postgresql.conf" | nindent 4 }} | ||
| {{- tpl .Values.codeInsightsDB.additionalConfig . | nindent 4 | trim }} |
Member
Author
There was a problem hiding this comment.
-- remove the extra new line above
9ecc08e to
7432e7d
Compare
caugustus-sourcegraph
approved these changes
Apr 11, 2022
Contributor
There was a problem hiding this comment.
One small concern about the info text but functionally looks good
a088a42 to
e032d7e
Compare
caugustus-sourcegraph
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR copied the updated pg-conf from sourcegraph/deploy-sourcegraph-docker#792
Also, we use
Files.Gettemplate function to reference the static file to keep configmap template clean. My eyes will hurt less next time I have to update the postgresql.conf :)Checklist
Test plan
helm template sourcegraph charts/sourcegraph/. > bundle.yamlall configmaps look good