8000 Add support to customize pg conf by michaellzc · Pull Request #792 · sourcegraph/deploy-sourcegraph-docker · GitHub
[go: up one dir, main page]
Skip to content
  • Insights

    • Add support to customize pg conf #792

    New issue

    Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

    Sign up for GitHub

    By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

    Already on GitHub? Sign in to your account

    Jump to bottom
    Merged
    michaellzc merged 6 commits into from
    Apr 12, 2022
    Merged

    Add support to customize pg conf #792

    michaellzc merged 6 commits into from
    Apr 12, 2022

    Conversation

    @michaellzc
    Copy link
    Member
    @michaellzc michaellzc commented Apr 5, 2022 •
    edited
    Loading

    Part of

    Learn more https://docs.google.com/document/d/1MzTpztUW-R8qARjQjYngA62LM64Y6OSImI04J_DPXTQ/edit

    Checklist

    Test plan

    cat docker-compose.yaml | yq '.services[].cpus = 0' > docker-compose.local-dev.yaml
    docker-compose -f docker-compose.local-dev.yaml up -d

    @michaellzc michaellzc changed the title wip Add support to customize pg conf Apr 5, 2022
    @michaellzc michaellzc marked this pull request as draft April 5, 2022 19:52
    @michaellzc michaellzc force-pushed the michael/support-custo-pg-conf branch 2 times, most recently from 36fbb0e to e53e36f Compare April 5, 2022 22:28
    michaellzc
    michaellzc commented Apr 5, 2022
    View reviewed changes
    michaellzc
    michaellzc commented Apr 5, 2022
    View reviewed changes
    michaellzc
    michaellzc commented Apr 5, 2022
    View reviewed changes
    @michaellzc michaellzc force-pushed the michael/support-custo-pg-conf branch from e53e36f to 3ddbf63 Compare April 5, 2022 22:40
    caugustus-sourcegraph
    caugustus-sourcegraph reviewed Apr 6, 2022
    View reviewed changes
    caugustus-sourcegraph
    caugustus-sourcegraph reviewed Apr 6, 2022
    View reviewed changes
    @michaellzc michaellzc force-pushed the michael/support-custo-pg-conf branch from 515f399 to 5c0d886 Compare April 8, 2022 00:03
    caugustus-sourcegraph
    caugustus-sourcegraph approved these changes Apr 8, 2022
    View reviewed changes
    Copy link
    Contributor
    @caugustus-sourcegraph caugustus-sourcegraph left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    👍 Some followup actions but overall it's a great improvement! We can copy the same streamlined conf to helm too. Maybe even kustomize? Not sure it's worth introducing huge merge conflicts there.

    Although.. is there any reason we shouldn't build these defaults in to the docker images? I guess it could be a bad idea for local development.

    michaellzc
    michaellzc commented Apr 8, 2022
    View reviewed changes
    @michaellzc michaellzc marked this pull request as ready for review April 9, 2022 03:48
    @michaellzc michaellzc mentioned this pull request Apr 9, 2022
    Merged
    1 task
    @caugustus-sourcegraph caugustus-sourcegraph mentioned this pull request Apr 11, 2022
    Merged
    4 tasks
    @michaellzc michaellzc force-pushed the michael/support-custo-pg-conf branch from 3cf5602 to 5425f26 Compare April 12, 2022 00:01
    @michaellzc michaellzc mentioned this pull request Apr 12, 2022
    Merged
    @michaellzc michaellzc merged commit 72e3ec4 into master Apr 12, 2022
    @michaellzc michaellzc deleted the michael/support-custo-pg-conf branch April 12, 2022 15:36
    @michaellzc michaellzc mentioned this pull request Apr 12, 2022
    Closed
    @keegancsmith keegancsmith mentioned this pull request Apr 20, 2022
    Merged
    1 task
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    1 more reviewer

    @caugustus-sourcegraph caugustus-sourcegraph caugustus-sourcegraph approved these changes

    Reviewers whose approvals may not affect merge requirements

    Assignees

    No one assigned

    Labels

    None yet

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    3 participants

    @michaellzc @caugustus-sourcegraph
    0