Split up Repository object #681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far we have two Repository objects (ShortRepository, Repository). In looking at API responses, it seems GitHub has removed many Repository attributes altogether. I'll need to investigate this further. Related-to: gh-670
It isn't exactly correct, but it's better than compromising on the design of Repository.
Fix-up some tests so I can re-record them as well
While re-recording cassettes I discovered a couple tiny bugs
13 tasks
Finally, update PullDestination to use ShortRepository
Conflicts: - github3/github.py - github3/users.py - tests/cassettes/GitHub_create_issue.json - tests/cassettes/Issue_events.json - tests/cassettes/Issue_pull_request.json - tests/cassettes/Milestone_labels.json - tests/cassettes/Organization_create_repository.json - tests/cassettes/Organization_repositories.json - tests/cassettes/PullRequest_issue.json - tests/cassettes/Repository_create_issue.json - tests/cassettes/Repository_events.json - tests/cassettes/Repository_issue.json - tests/cassettes/Repository_issue_events.json - tests/cassettes/Repository_issues_ascending.json - tests/cassettes/Repository_issues_state_all.json - tests/cassettes/Repository_network_events.json - tests/cassettes/Team_repositories.json - tests/cassettes/User_events.json - tests/cassettes/User_organization_events.json - tests/integration/test_users.py - tests/unit/json/pull_request_example - tox.ini
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far we have two Repository objects (ShortRepository, Repository). In
looking at API responses, it seems GitHub has removed many Repository
attributes altogether. I'll need to investigate this further.
Related-to: gh-670