Add support for repository PR merge settings #706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see 80 column linter error, will resolve.. |
|
This requires a to call From github's API, seems you only get to know these values on CREATE and EDIT and other operations. I'm not sure how to accommodate it with github3.py model, please suggest. |
|
The Repository object is getting refactored, so it may be best to wait until #681 lands and then re-base this work on top of that. |
From GitHub documentation, https://help.github.com/articles/configuring-pull-request-merges/ We may use the repository settings page to forcefully enable or disable any of the given options for pull request merges, this commit allows setting the values allow_rebase_merge, allow_squash_merge, and allow_merge_commit as keywords for the repo.edit() method.
|
I've rebased this. I'm not sure if there's a good case for a cassette to verify this behaviour, though, so I'm fine merging this as is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From GitHub documentation,
https://help.github.com/articles/configuring-pull-request-merges/
We may use the repository settings page to forcefully enable or disable
any of the given options for pull request merges, this commit allows
setting the values allow_rebase_merge, allow_squash_merge, and
allow_merge_commit as keywords for the repo.edit() method.