10000 Add support for repository PR merge settings · Pull Request #706 · sigmavirus24/github3.py · GitHub
[go: up one dir, main page]

Skip to content

Add support for repository PR merge settings #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from Apr 19, 2018
Merged

Add support for repository PR merge settings #706

merged 1 commit into from Apr 19, 2018

Conversation

ghost
Copy link
@ghost ghost commented May 19, 2017

From GitHub documentation,

https://help.github.com/articles/configuring-pull-request-merges/

We may use the repository settings page to forcefully enable or disable
any of the given options for pull request merges, this commit allows
setting the values allow_rebase_merge, allow_squash_merge, and
allow_merge_commit as keywords for the repo.edit() method.

@ghost
Copy link
Author
ghost commented May 19, 2017

I see 80 column linter error, will resolve..

8000

@ghost
Copy link
Author
ghost commented May 19, 2017

This requires a to call repo.refresh() before attributes like repo.allow_merge_commit become non-None.

From github's API, seems you only get to know these values on CREATE and EDIT and other operations.

I'm not sure how to accommodate it with github3.py model, please suggest.

@omgjlk
Copy link
Collaborator
omgjlk commented Dec 18, 2017

The Repository object is getting refactored, so it may be best to wait until #681 lands and then re-base this work on top of that.

From GitHub documentation,

   https://help.github.com/articles/configuring-pull-request-merges/

We may use the repository settings page to forcefully enable or disable
any of the given options for pull request merges, this commit allows
setting the values allow_rebase_merge, allow_squash_merge, and
allow_merge_commit as keywords for the repo.edit() method.
@sigmavirus24
Copy link
Owner

I've rebased this. I'm not sure if there's a good case for a cassette to verify this behaviour, though, so I'm fine merging this as is.

@sigmavirus24 sigmavirus24 merged commit ca67d2b into sigmavirus24:develop Apr 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0