Picking up #599 Add retrieving of the combined status of a RepoCommit #663
Conversation
dca0ac8 to
5ac0f70
Compare
|
ping? |
|
Sorry that I lost track of this @mindw. This looks good to me. @itsmemattchung do you have time to write some integration tests and record a test for this? |
Thanks for writing this @mindw . @sigmavirus24 I do indeed have time to write and record a test (or tests); earliest is this evening, latest is this weekend. |
|
@itsmemattchung can you please point to or describe how it that done? I was unable to find it on my own. |
|
Sure—you can find the documentation here. Also, to get you started, here's an example integration test: get_pull_request. Basically, our integration test capture the HTTP request/response and persist the file to JSON; the file is then replayed (using Betamax, also written by @sigmavirus24 ) to ensure that new changes don't accidentally modify HTTP requests (headers, uri, etc). Feel free to ping either of us. |
|
@mindw let me know if you want to give the tests a shot; if not, I'll take a stab this weekend. |
- Update @Vampire's work to account for Empty. - Add tests for combined status - Add changelog entry
5ac0f70 to
6c73f1e
Compare
|
Ah, nice, thanks for polishing it @mindw and @sigmavirus24 :-) |
@Vampire 's #599 and:
Best to squash-merge if/once approved.