8000 Add retrieving of the combined status for a RepoCommit by Vampire · Pull Request #599 · sigmavirus24/github3.py · GitHub
[go: up one dir, main page]
Skip to content

Add retrieving of the combined status for a RepoCommit #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add retrieving of the combined status for a RepoCommit #599

wants to merge 1 commit into from

Conversation

Vampire
Copy link
Contributor
@Vampire Vampire commented Apr 18, 2016

Retrieving of the combined status of a commit was missing from the API.
This adds it.

@sigmavirus24
Copy link
Owner

Hi @Vampire! Thanks for the pull request :)

You seem to be missing tests and the existing tests all seem to be failing (although I think I know why and it's unrelated to your pull request).

I also see that you updated one of the example Python Notebooks. Instead of updating an existing one, could you just add a new one?

Thanks!
Ian

@Vampire
Copy link
Contributor Author
Vampire commented Apr 18, 2016 •
edited
Loading

Well, I can try. I'm no Python developer usually, I'm mostly a Java guy mainly.
And I was not able to get the tests running properly, less knowing how to properly write test in Python.
About the Notebook, yeah, I updated the status-api notebook as the combined status is part of the status api, but if you prefer I can also create a new one.

Btw. what is it that makes the test failing if it is not my PR?

@Vampire
Copy link
Contributor Author
Vampire commented Apr 21, 2016

@sigmavirus24 any news?

@megies
Copy link
megies commented Sep 30, 2016

I'm doing something similar here. Just in case it might help here..

@mindw mindw mentioned this pull request Dec 31, 2016
Merged
sigmavirus24 added a commit that referenced this pull request Jan 27, 2017
@sigmavirus24
Merge pull request #663 from mindw/Vampire/combined-status
5544e97 
Picking up #599  Add retrieving of the combined status of a RepoCommit
@Vampire Vampire deleted the combined-status branch April 14, 2017 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Vampire @sigmavirus24 @megies
0