10000 Use sfs.default object instead of sfs.defs submodule by mgeier · Pull Request #84 · sfstoolbox/sfs-python · GitHub
[go: up one dir, main page]
Skip to content

Use sfs.default object instead of sfs.defs submodule #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 27, 2019
Merged

Use sfs.default object instead of sfs.defs submodule #84

merged 2 commits into from
Feb 27, 2019

Conversation

mgeier
Copy link
Member
@mgeier mgeier commented Feb 11, 2019

See #32.

@hagenw
Copy link
Member
hagenw commented Feb 12, 2019

I like your changes 👍

Would be great if you could integrate them in the documentation as well. I think it would be nice if we tell a user how she/he could change the default speed of sound.

@mgeier
Copy link
Member Author
mgeier commented Feb 18, 2019

What about 8564d71?

I was hesitating to add this to the docs, because it's a bit messy.

Does anyone have an idea how to do this in a cleaner way?

@mgeier
Copy link
Member Author
mgeier commented Feb 19, 2019

#45 and #69 should be merged before this PR because they use sfs.defs a few times.

@mgeier
Copy link
Member Author
mgeier commented Feb 26, 2019

I've moved the autosummarydirective in a4c7c8c.

This way, sfs.default is documented directly on the main API page and not on a separate page.

I think that's better.

Any other opinions?

@mgeier mgeier merged commit a4c7c8c into master Feb 27, 2019
@mgeier mgeier deleted the default branch February 27, 2019 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgeier @hagenw
0