8000 Rename "defs"? · Issue #32 · sfstoolbox/sfs-python · GitHub
[go: up one dir, main page]
Skip to content

Rename "defs"? #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mgeier opened this issue Dec 20, 2016 · 0 comments
Closed

Rename "defs"? #32

mgeier opened this issue Dec 20, 2016 · 0 comments

Comments

@mgeier
Copy link
Member
mgeier commented Dec 20, 2016

The submodule sfs.defs is supposed to mean "defaults".
This is quite accurate, since it contains default values.

However, if we would rename it to default, it would make more sense when reading it, e.g. sfs.default.c reads like "default c", not like "defaults c".

Apart from renaming, we could also turn it into an object of a custom class, like e.g. http://python-sounddevice.readthedocs.io/#sounddevice.default
This way, we could avoid accidentally assigning unsupported attributes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mgeier
0