8000 Update to references by hagenw · Pull Request #49 · sfstoolbox/sfs-python · GitHub
[go: up one dir, main page]

Skip to content

Update to references #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 28, 2017
Merged

Update to references #49

merged 3 commits into from
Nov 28, 2017

Conversation

hagenw
Copy link
Member
@hagenw hagenw commented Nov 28, 2017

This includes:
1.) Update the references to the source image model from #42 to be in line with #46 by moving them to the extra doc/references.rst file
2.) Cleaning up doc/references.rst by introducing line breaks
3.) Fixing a typo

Copy link
Member
@mgeier mgeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I like the line breaks!

I was just wondering about the algorithm to generate the keys.

Why stop combining authors at two?
I think the only consistent options are either using only ever the first name or using all names.

But anyway, this inconsistency was already there before your changes ...

@hagenw
Copy link
Member Author
hagenw commented Nov 28, 2017

If you do a citation in a paper you would use "Name1" for one author "Name1 and Name2" for two authors and "Name1 et al." for three or more authors. That was the idea behind the referencing and it is the same as in SFS theory.

But I agree that most probably it would be better to use just one name here as I'm also not willing to add "etal" into the brackets. I will merge this first and then think again about it.

8000 @hagenw hagenw merged commit 4ab97fc into master Nov 28, 2017
@hagenw hagenw deleted the fix_refs branch November 28, 2017 20:56
@mgeier
Copy link
Member
mgeier commented Nov 29, 2017

Yes, "Name1 and Name2 (2007)" or "(Name1 and Name2, 2007)" would be fine, but "[Name1Name22007]" is an entirely different thing.

Did you ever try https://github.com/mcmtroffaes/sphinxcontrib-bibtex?

@hagenw
Copy link
Member Author
hagenw commented Nov 29, 2017

I thought about it, but I never tried. It is a little bit buggy using multiple pages, but I will test it.

@mgeier
Copy link
Member
mgeier commented Nov 30, 2017

I wasn't aware of the multi-page issue, but using :all: doesn't sound too bad, does it?
Why would we want to have unused entries in our bibtex file anyway?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0